Bug 533198 - branch name validation is slow for big repositories
Summary: branch name validation is slow for big repositories
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 4.11   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 5.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2018-04-04 05:27 EDT by Michael Keppler CLA
Modified: 2018-10-19 00:00 EDT (History)
2 users (show)

See Also:

Attachments
profiler screenshot (16.00 KB, image/png)
2018-04-04 05:27 EDT, Michael Keppler CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2018-04-04 05:27:48 EDT 
Created attachment 273413 [details]
profiler screenshot

When typing random characters fastly into the branch name field (on the platform.ui repository), it takes roughly half a second for each character to appear. This is due to jgit checking for name conflicts in org.eclipse.jgit.lib.RefDatabase.getConflictingNames(String), see profiler screenshot.

This is not the same as #352253, #405143 or similar, which were about the UI taking a lot of time to re-layout the (previous) combobox.

I'll try to create a patch for running the validation in a job.
Comment 1 Eclipse Genie CLA 2018-04-04 05:57:00 EDT 
New Gerrit change created: https://git.eclipse.org/r/120691
Comment 2 Eclipse Genie CLA 2018-04-25 04:45:10 EDT 
Gerrit change https://git.eclipse.org/r/120691 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=455a6c3648c9dbc04fe7c82b2bb8d3ef91797825