Comment 1 Andrey Loskutov 2018-03-30 06:03:44 EDT

@Sarika: shouldn't this go to 4.7.3a too?

Comment 2 Eclipse Genie 2018-03-30 06:03:48 EDT

New Gerrit change created: https://git.eclipse.org/r/120504

Comment 3 Sarika Sinha 2018-03-30 06:19:15 EDT

(In reply to Andrey Loskutov from comment #1)
> @Sarika: shouldn't this go to 4.7.3a too?

Will let it go in 4.8 only.

JLS8 ones should be changed to 10 but we need to be careful for the ones which are having JLS4.

Comment 4 Andrey Loskutov 2018-04-02 14:55:07 EDT

(In reply to Sarika Sinha from comment #3)
> JLS8 ones should be changed to 10 but we need to be careful for the ones
> which are having JLS4.

Sarika, can you give some details why places with JLS4 should be differently handled?

Comment 5 Sarika Sinha 2018-04-03 06:53:10 EDT

(In reply to Andrey Loskutov from comment #4)
> (In reply to Sarika Sinha from comment #3)
> > JLS8 ones should be changed to 10 but we need to be careful for the ones
> > which are having JLS4.
> 
> Sarika, can you give some details why places with JLS4 should be differently
> handled?

Because we have not upgraded it like other places. I am not aware of the history why they were not changed like other places.

Comment 6 Alexander Kurtakov 2018-08-17 09:31:49 EDT

Is this missing 4.9 ?

Comment 7 Sarika Sinha 2018-09-05 08:13:29 EDT

We can switch to JLS 11 in 4.10 M1.

Comment 8 Sarika Sinha 2019-05-16 00:53:16 EDT

Could not find time in 4.12

Comment 9 Lars Vogel 2021-04-07 10:55:54 EDT

Looks like JDT provides JLS_Latest these days in org.eclipse.jdt.core.dom.AST

Sarika, can we switch to that constant?

Comment 10 Sarika Sinha 2021-04-07 12:01:15 EDT

(In reply to Lars Vogel from comment #9)
> Looks like JDT provides JLS_Latest these days in org.eclipse.jdt.core.dom.AST
> 
> Sarika, can we switch to that constant?

Yes we can.

Comment 11 Eclipse Genie 2021-04-09 02:07:05 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179076

Comment 12 Eclipse Genie 2021-04-09 02:07:48 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179077

Comment 13 Sarika Sinha 2021-04-09 02:28:18 EDT

(In reply to Eclipse Genie from comment #12)
> New Gerrit change created:
> https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179077

Can we please have it in 1 gerrit?

Comment 14 Lars Vogel 2021-04-09 02:35:21 EDT

(In reply to Sarika Sinha from comment #13)
> (In reply to Eclipse Genie from comment #12)
> > New Gerrit change created:
> > https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179077
> 
> Can we please have it in 1 gerrit?

So the change in the test code is also fine?

Comment 15 Sarika Sinha 2021-04-09 02:52:49 EDT

(In reply to Lars Vogel from comment #14)
> (In reply to Sarika Sinha from comment #13)
> > (In reply to Eclipse Genie from comment #12)
> > > New Gerrit change created:
> > > https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179077
> > 
> > Can we please have it in 1 gerrit?
> 
> So the change in the test code is also fine?

I have not looked at this test, but in general, unless a test is testing some special feature from a particular Java version we can update it to latest.

Comment 16 Lars Vogel 2021-04-09 03:32:21 EDT

(In reply to Sarika Sinha from comment #15)
> > > Can we please have it in 1 gerrit?

Merged with previous Gerrit, https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/179076

Comment 17 Eclipse Genie 2023-04-05 14:14:25 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.