Bug 532972 - feature: Make CPU Resources view more easy to read for Android trace
Summary: feature: Make CPU Resources view more easy to read for Android trace
Status: UNCONFIRMED
Alias: None
Product: Tracecompass
Classification: Tools
Component: Core (show other bugs)
Version: 3.3.0   Edit
Hardware: PC Linux
: P3 major
Target Milestone: 4.0.0   Edit
Assignee: Patrick Tasse CLA
QA Contact: Project Inbox CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-27 23:22 EDT by Joel Fernandes CLA
Modified: 2018-06-15 21:21 EDT (History)
3 users (show)

See Also:


Attachments
Add distance between rows and make row wider (17.63 KB, image/png)
2018-03-27 23:22 EDT, Joel Fernandes CLA
no flags Details
EXAMPLE (17.63 KB, image/png)
2018-03-27 23:30 EDT, Joel Fernandes CLA
no flags Details
EXAMPLE (40.46 KB, image/jpeg)
2018-03-27 23:32 EDT, Joel Fernandes CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Fernandes CLA 2018-03-27 23:22:20 EDT
Created attachment 273330 [details]
Add distance between rows and make row wider

At the moment, the trace-compass android trace view doesn't space CPUs well from each other.

2 data points are shown per CPU. One for the Threads, and other for the states. That's great! However, the next CPU's Threads/States row should have some distance from the previous CPU's Threads/States row. For large number of CPUs, it will get confusing and the user has to visually put in an effort to separate them.

Also, the rows are pretty narrow (vertical width), it'll be nice if they can be made thicker. Right now it looks like the top/bottom of the text touches the top/bottom of the row that the text is placed in.

Attached is an example showing the request.
Comment 1 Joel Fernandes CLA 2018-03-27 23:30:13 EDT
Created attachment 273331 [details]
EXAMPLE
Comment 2 Joel Fernandes CLA 2018-03-27 23:32:04 EDT
Created attachment 273332 [details]
EXAMPLE
Comment 3 Genevieve Bastien CLA 2018-03-28 10:23:38 EDT
Adding spacing between CPU-related entries is a good idea, not just for Android.

We just switched our API to provide the data to populate the views and I think it would be a good time to provision for that. In addition to the entries and their parent/child relationship, we could add a concept of grouping that views could interpret as a hint to visually separate the entries for a given group.

Additionnally, this concept could be useful for the eventual containter analysis and views.
Comment 4 Loic Prieur-Drevon CLA 2018-03-28 10:27:48 EDT
when adding the current_thread line, we had discussed a top level element per CPU,

CPU {nb} - (Maybe use this line for something?)
 - Status
 - Current Thread
 - Frequency
Comment 5 Eclipse Genie CLA 2018-04-24 17:22:42 EDT
New Gerrit change created: https://git.eclipse.org/r/121691
Comment 7 Patrick Tasse CLA 2018-05-10 15:56:28 EDT
Merged to master branch.
Comment 8 Joel Fernandes CLA 2018-06-15 21:21:48 EDT
Just reopening this bug, it seems the spacing between one CPU's Threads/State is still not enough from another CPU's thread state. When viewing a large number of CPUs, it still appears confusing. Is it possible to increase the spacing even more?

Also one more request wasn't addressed from the original bug:
the rows are pretty narrow (vertical width), it'll be nice if they can be made thicker. Right now it looks like the top/bottom of the text touches the top/bottom of the row that the text is placed in.

Thanks for the first pass. I have reopened this bug considering the above pending requests.