Bug 532839 - Zest NodePart - Improve the Stroketype handling
Summary: Zest NodePart - Improve the Stroketype handling
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF Zest (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-23 12:05 EDT by Tamas Miklossy CLA
Modified: 2018-03-23 12:05 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Miklossy CLA 2018-03-23 12:05:46 EDT 
The Zest Node Part (org.eclipse.gef.zest.fx.parts.NodePart) sets the Stroke Type of a shape to StrokeType.INSIDE by default when refreshing the node shape in the refreshShape() method. This current behavior is hardly customizable by adopters, therefore should be improved by:

- changing the visibility of the refreshShape() method to protected.
- modifying the implementation of the refreshShape() method to not set the stroke type.
- zest has to ensure that the resize functionality still properly working.