Bug 532756 - Check ContainerSWTRenderer Constructor
Summary: Check ContainerSWTRenderer Constructor
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P5 normal (vote)
Target Milestone: 1.20.0   Edit
Assignee: Jonas Helming CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2018-03-22 07:54 EDT by Eugen Neufeld CLA
Modified: 2019-02-04 06:50 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugen Neufeld CLA 2018-03-22 07:54:11 EDT 
The containerswtrenderer costructor expects EMFFormsDatabinding and EMFFormsRendererFactory.
We should check whether this is needed as they can be retrieved from the ViewModelContext.
Also check all classes extending the containerswtrenderer
Comment 1 Eugen Neufeld CLA 2018-08-22 09:35:47 EDT 
Mass Move due to time constraints
Comment 2 Eugen Neufeld CLA 2018-11-06 04:40:59 EST 
Mass move to 1.20 due to time constraints.
Comment 3 Jonas Helming CLA 2018-11-28 11:36:47 EST 
factory is need, but databinding is superflouous
Comment 4 Jonas Helming CLA 2018-11-28 11:37:55 EST 
Testing information:
This changes the API of the containerrenderer. You do not need the databinding parameter anymore, but you can also not retrieve it. If you require a databinding in a subclass, just directly get it injected instead
Comment 5 Eclipse Genie CLA 2018-11-28 11:39:11 EST 
New Gerrit change created: https://git.eclipse.org/r/133193