Comment 1 Fred Bricon 2018-03-12 10:13:10 EDT

Oh so WTP doesn't provide a 2.3 facet, so we need that 1st in order to implement support in m2e-wtp

Comment 2 John Collier 2018-03-13 16:59:58 EDT

Moving to JSF Tools, as that's the WTP project responsible for JSF support.

Comment 3 Lakshminarayana 2018-07-29 14:36:24 EDT

Basic `JSF 2.3` support added here.

https://github.com/lak-proddev/webtools.jsf/commit/e0f31498f4d64d6d247eb43bd18c7a8f56dbaba8


I tested some sample applications on Payara 5
https://github.com/hantsy/ee8-sandbox.git

Comment 4 Eclipse Genie 2018-07-31 00:03:03 EDT

GitHub Pull Request 1 created by [lak-proddev]
https://github.com/eclipse/webtools.jsf/pull/1

Comment 5 Eclipse Genie 2018-08-01 16:23:43 EDT

New Gerrit change created: https://git.eclipse.org/r/126915

Comment 6 Nick Boldt 2018-08-01 16:24:14 EDT

We don't have gh pull request builds enabled, so I've resubmitted your PR as a gerrit:

https://git.eclipse.org/r/126915

Comment 7 Eclipse Genie 2018-08-01 16:48:01 EDT

Gerrit change https://git.eclipse.org/r/126915 was merged to [master].
Commit: http://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=49060e54a5b1124c21b105d32d2408b7c5233a94

Comment 8 Nick Boldt 2018-08-01 16:49:29 EDT

And done. Thanks for the contribution! Please use gerrit next time and you'll get more credit. :D

Comment 9 Lakshminarayana 2018-08-02 02:38:56 EDT

(In reply to Nick Boldt from comment #8)
> And done. Thanks for the contribution! Please use gerrit next time and
> you'll get more credit. :D

Sure.
Please, make sure that the Jsf 2.3 libs available at this location.
http://www.eclipse.org/webtools/jsf/jsf-library/jsf-2.3-downloadable-libraries.xml

See this code.You can understand better.
<extension
        point="org.eclipse.jst.common.project.facet.core.downloadableLibraries">
     <import-definitions
           url="http://www.eclipse.org/webtools/jsf/jsf-library/jsf-2.3-downloadable-libraries.xml">
        <enablement>
           <with
                 variable="requestingProjectFacet">
              <test
                    forcePluginActivation="true"
                    property="org.eclipse.wst.common.project.facet.core.projectFacet"
                    value="jst.jsf:2.3">
              </test>
           </with>
        </enablement>
     </import-definitions>
  </extension>

Comment 10 Nick Boldt 2018-08-02 10:22:13 EDT

Houston, we have a problem.

Looking at the jsf 2.2 file [1] I see a reference to a zip that doesn't exist [2].

[1] https://www.eclipse.org/webtools/jsf/jsf-library/jsf-2.2-downloadable-libraries.xml
[2] https://java.net/downloads/javaserverfaces/release/mojarra-2.2.0-FCS-binary.zip

So... the jsf 2.2 file is broken, and I can't use it as a reference to create a 2.3 file.

I had a look at the releases [3] for mojarra 2.3 and newer 2.2.x but those zips don't include javax.faces.jar, so I could update the jsf-2.2 file to this new one but I'm not sure it's compatible. 

[3] https://github.com/javaserverfaces/mojarra/releases

I looked in mojarra-2.2.8-29.zip, mojarra-2.2.17.zip, and mojarra-2.3.6.zip, all of which have a lib folder but it contains these jars instead:

* jsf-extensions-test-time.jar
* javax.servlet.jar
* injectionproviders.jar
* cactus-1.7.1-javaee5.jar

Should I just include those jars instead, from the latest 2.2.x and 2.3.x releases [3] ?

Comment 11 Nick Boldt 2018-08-02 10:28:04 EDT

Or I guess I can pull jars from here: https://javaserverfaces.github.io/download.html but ... they're not inside zips, and are only referenced via maven GAV, not a <library>. 

Help? I have no idea how this stuff works.