Community
Participate
Working Groups
In the Execution environment dialog and the EE drop down in Edit Library dialog the Java-SE-10 appears before Java-SE-9 in the list. Looks like the alphabatical sorting needs an exception here.
I think this is handled in JDT Debug.
It will definitely be good to have JavaSE-10 after Java SE-9. But --- Even JRE 1.1 comes after J2SE 1.5
Created attachment 273133 [details] Sorting by Compliance Sorting by compliance changes the existing order for CDC and OSGi EEs.
Same applies to compliance target level source level
(In reply to Dani Megert from comment #4) > Same applies to > compliance > target level > source level I mean there also 10 needs to be after 9 if not already done so.
New Gerrit change created: https://git.eclipse.org/r/119559
New Gerrit change created: https://git.eclipse.org/r/119561
New Gerrit change created: https://git.eclipse.org/r/119563
(In reply to Eclipse Genie from comment #8) > New Gerrit change created: https://git.eclipse.org/r/119563 @Vikas , This is for pde Eclipse Application launch sorting. We will need BETA_JAVA_18_3 branch for pde.ui I have currently created the patch on master.
Created attachment 273157 [details] New EE Sorting New EE Sorting
(In reply to Sarika Sinha from comment #10) > Created attachment 273157 [details] > New EE Sorting > > New EE Sorting Just a suggestion: it can be sorted in the reverse order if everyone agrees. It will be applicable to the drop-down combos also. That will bring the frequently used (latest) EEs (1.8/9/10) to the top and will avoid the distraction from the old EEs (CDC/OSGi/J2SE).
(In reply to comment #11) > (In reply to Sarika Sinha from comment #10) > > Created attachment 273157 [details] > > New EE Sorting > > > > New EE Sorting > Just a suggestion: it can be sorted in the reverse order if everyone agrees. It > will be applicable to the drop-down combos also. > > That will bring the frequently used (latest) EEs (1.8/9/10) to the top and will > avoid the distraction from the old EEs (CDC/OSGi/J2SE). +1
(In reply to Noopur Gupta from comment #11) > (In reply to Sarika Sinha from comment #10) > > Created attachment 273157 [details] > > New EE Sorting > > > > New EE Sorting > Just a suggestion: it can be sorted in the reverse order if everyone agrees. > It will be applicable to the drop-down combos also. > > That will bring the frequently used (latest) EEs (1.8/9/10) to the top and > will avoid the distraction from the old EEs (CDC/OSGi/J2SE). As stated yesterday I also prefer the reverse order. @Dani, Please suggest as yesterday in the meeting you clarified that Java 10 should always come after Java 9.
(In reply to Sarika Sinha from comment #13) > (In reply to Noopur Gupta from comment #11) > > (In reply to Sarika Sinha from comment #10) > > > Created attachment 273157 [details] > > > New EE Sorting > > > > > > New EE Sorting > > Just a suggestion: it can be sorted in the reverse order if everyone agrees. > > It will be applicable to the drop-down combos also. > > > > That will bring the frequently used (latest) EEs (1.8/9/10) to the top and > > will avoid the distraction from the old EEs (CDC/OSGi/J2SE). > > > As stated yesterday I also prefer the reverse order. > > @Dani, Please suggest as yesterday in the meeting you clarified that Java 10 > should always come after Java 9. It is too late to change that long known order at this point. And we have to make sure that we fix it at all places, not just for EEs. Please file a new bug to look at this after 4.8.
The patches attached change the sorting in 1) Windows preference page for EE 2) List of EE in New Java Project Wizard 3) List of EE in Java application, Eclipse Application
Gerrit change https://git.eclipse.org/r/119559 was merged to [BETA_JAVA_18_3]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=dd7ddc4b28e8f191657973edb30c43a3b9cd7785
Gerrit change https://git.eclipse.org/r/119561 was merged to [BETA_JAVA_18_3]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=5299fe582a1bd9377a138bffa3ece53b2538aa57
>>This is for pde Eclipse Application launch sorting. I will test this and put the fix directly post merge. If in case merge happens to take time ( later than this wednesday/thursday), I will create a PDE 18.3 stream and put this in.
(In reply to Vikas Chandra from comment #18) > I will test this and put the fix directly post merge. If in case merge > happens to take time ( later than this wednesday/thursday), I will create a > PDE 18.3 stream and put this in. Sorry, this is gibberish.
>>Sorry, this is gibberish. Which part of this is gibberish? This is an action item for comment 9. If you have an alternate and better action item, please suggest.
New Gerrit change created: https://git.eclipse.org/r/119745
Gerrit change https://git.eclipse.org/r/119745 was merged to [BETA_JAVA_18_3]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=c1f35b324d76b6cb48523cc2efcc4fc68024819b
Some more testing revealed that order in File->New -> Plugin Project, on the content page, we have the old order. Sarika, can you please take it up?
(In reply to Vikas Chandra from comment #20) > >>Sorry, this is gibberish. > > Which part of this is gibberish? All. I just don't understand what you plan to do or tried to say. For example, what is a "PDE 18.3 stream"?
>>"PDE 18.3 stream" This means a "code branch in PDE that will be contain changes for Java18.3/Java10 changes in PDE". Not the best of phrases but it conveyed the message pretty well.
>>I just don't understand what you plan to do or tried to say The update here right now is that I created a PDE source code branch which is named as "BETA_JAVA_18_3". The code of comment 9 is committed in "BETA_JAVA_18_3" branch via comment 22. I have found an issue ( reported via comment comment 23). Hope things are clear now.
(In reply to Vikas Chandra from comment #26) > >>I just don't understand what you plan to do or tried to say > > > The update here right now is that I created a PDE source code branch which > is named as "BETA_JAVA_18_3". The code of comment 9 is committed in > "BETA_JAVA_18_3" branch via comment 22. > > I have found an issue ( reported via comment comment 23). > > Hope things are clear now. Better now :-)
New Gerrit change created: https://git.eclipse.org/r/119840
(In reply to Eclipse Genie from comment #28) > New Gerrit change created: https://git.eclipse.org/r/119840 @Vikas, this handles the scenario mentioned in comment 23. Please review.
New Gerrit change created: https://git.eclipse.org/r/119852
Gerrit change https://git.eclipse.org/r/119852 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=94c46b2ea97d8cde4626556d44b7791c9dc3f2df
New Gerrit change created: https://git.eclipse.org/r/119855
Created attachment 273237 [details] I see J2SE-1.3-NO-SOUND instead of just J2SE-1.3 Is this expected?
(In reply to Vikas Chandra from comment #33) > Created attachment 273237 [details] > I see J2SE-1.3-NO-SOUND instead of just J2SE-1.3 > > Is this expected? I don't get it. Is this coming from your test plugn?
Gerrit change https://git.eclipse.org/r/119855 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=d848a1914ef81dd9a82ec92967bf5798742ca60c
>>I don't get it. Is this coming from your test plugn? I will check it and update my findings on the bug. Meanwhile, I've committed your last change so that it can be picked up by the 4.7.3a build(RC1 candidate).
New Gerrit change created: https://git.eclipse.org/r/119943
Gerrit change https://git.eclipse.org/r/119943 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=e87f66ed4733417667f69e95cd832085fb28b33e
Verified with Eclipse SDK Version: Photon (4.8) Build id: I20180322-0645 @Vikas, I don't see that extra entry.
Verified using Eclipse SDK Version: Oxygen.3a (4.7.3a) Build id: M20180323-1030 Created Bug 532877 for reconsidering sorting order.
