Description Pierre-Charles David 2018-02-27 03:40:20 EST

Created attachment 272897 [details]
Sample project to reproduce the issue

DesignServices.getDisplayedEClasses and related methods use DDiagramQuery.getAllDiagramElements() to obtain all the DNodeLists, but that method also returns all the edges, nodes and list elements. This adds up and causes performance issues.

Using the attached project, with a single diagram showing 1500 EClasses, 1500 EAttributes and 2500 EReferences, opening the diagram takes around 16s, with DesignServices.getDisplayedEClasses identified as a hot spot.

I'll push a patch on Gerrit which uses new DDiagramInternalQuery(diagram).getContainers() instead on several methods of DesignServices. It uses an internal method in Sirius, but results in a significant speedup: a little less than 7s (instead of 16) to open the diagram.