Bug 531370 - Agent*Importer::Import(): replace returned nullptr by false
Summary: Agent*Importer::Import(): replace returned nullptr by false
Status: UNCONFIRMED
Alias: None
Product: Openpass
Classification: Automotive
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal
Target Milestone: ---   Edit
Assignee: Project inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-20 04:41 EST by Reinhard Biegel CLA
Modified: 2018-02-20 04:54 EST (History)
0 users

See Also:

Attachments
proposed patch (2.29 KB, patch)
2018-02-20 04:41 EST, Reinhard Biegel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Reinhard Biegel CLA 2018-02-20 04:41:24 EST 
Created attachment 272743 [details]
proposed patch

At least gcc-7 in a Linux environment complains about casting nullptr to bool:

> error: converting to ‘bool’ from ‘std::nullptr_t’ requires direct-initialization [-fpermissive]

Attached you'll find my proposed patch.
Comment 1 Reinhard Biegel CLA 2018-02-20 04:54:28 EST 
NOTE:
As reported in bug 531371, I'm currently having problems with the line ending style. For the patch to apply in my local environment, I have to use the --binary option with the patch command.