Description Martin Hentschel 2018-02-13 04:28:27 EST

The method ModelDescriptorRegistry#internalGetModel(IFile) creates a copy of a Set which was created by Collections#synchronizedSet(Set) as follows:

    Set<IModelDescriptor> unsynchronizedModelDescriptorsForMMDescriptor = new HashSet<IModelDescriptor>(modelDescriptorsForMMDescriptor);

The problem is, that the constructor of the HashSet iterates over the set to copy without protecting it against concurrent access which must be done manually with a synchronized statement as documented in Collections#synchronizedSet(Set). Consequently, a ConcurrentModificationException is thrown by the constructor of the HashSet in case of concurrent access.

The obvious solution is:

    synchronized (modelDescriptorsForMMDescriptor) {
        Set<IModelDescriptor> unsynchronizedModelDescriptorsForMMDescriptor = new HashSet<IModelDescriptor>(modelDescriptorsForMMDescriptor);
    }

Please test carefully, that no deadlocks are introduced related to comment with the "Important Note".