Bug 530916 - UI thread can wait on index lock via CElementHyperlinkDetector
Summary: UI thread can wait on index lock via CElementHyperlinkDetector
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-editor (show other bugs)
Version: Next   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-08 21:17 EST by Nathan Ridge CLA
Modified: 2020-09-04 15:21 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Ridge CLA 2018-02-08 21:17:37 EST
CElementHyperlinkDetector runs on the UI thread, and it performs AST processing which can involve waiting on the index lock (if e.g. the indexer is busy writing to the index).

This is a bad combination because, particularly in the presence of indexer bugs (which we've always had and are probably always going to have), the indexer can hold the index lock for an unbounded amount of time, and we really shouldn't hold up the UI thread for an unbounded amount of time for any reason.