Bug 530782 - Import repository icons should use the same label provider as the repository view
Summary: Import repository icons should use the same label provider as the repository ...
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-06 08:25 EST by Lars Vogel CLA
Modified: 2018-02-07 13:34 EST (History)
1 user (show)

See Also:

Attachments
Screenshot (76.36 KB, image/png)
2018-02-06 08:25 EST, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2018-02-06 08:25:51 EST 
Created attachment 272555 [details]
Screenshot

The import dialog should use the same icon as the Git repository view. They are currently different for Gerrit repos.

See screenshot.

P.S. Bug 525600 indicates that Egit (or Thomas) is very concerned with using the correct icon. Hence this bug report
Comment 1 Thomas Wolf CLA 2018-02-07 13:34:00 EST 
(In reply to Lars Vogel from comment #0)
> Egit (or Thomas) is very concerned with using
> the correct icon. Hence this bug report

Yes, I think consistency is important.

Note that this particular dialog shows repositories to be imported. Egit hasn't read the repositories' metadata yet and doesn't know yet whether a repo is configured for Gerrit (or for gitflow). So we show the general repository icon.

EGit could read the repo metadata during the repo discovery file system scan, but that would slow down that scan. I don't know by how much -- it would have to be tried. But reading all the .git/config files isn't free.