Bug 530108 - Wrong contents of jar-in-jar-loader.zip
Summary: Wrong contents of jar-in-jar-loader.zip
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.7.3   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 529172
  Show dependency tree
 
Reported: 2018-01-22 03:18 EST by Guillermo Gutierrez Almazor CLA
Modified: 2018-01-23 04:29 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guillermo Gutierrez Almazor CLA 2018-01-22 03:18:23 EST 
After latest commit b9c6bd3dfbecb04471ca7d148a092eee4cc249a5 with changes on the loader's code, the zip file contains the old compiles classes.

The zip file should be updated to sync the source code with the compiled classes. 

I'm creating this bug to push a gerrit changeset with the new zip file.
Comment 1 Eclipse Genie CLA 2018-01-22 03:20:36 EST 
New Gerrit change created: https://git.eclipse.org/r/115783
Comment 2 Andrey Loskutov CLA 2018-01-22 03:22:54 EST 
OMG. I was not aware that we add generated classes to the source control. WHY?!?

Bug 529172 must be re-opened.
Comment 3 Eclipse Genie CLA 2018-01-22 03:46:06 EST 
New Gerrit change created: https://git.eclipse.org/r/115786
Comment 5 Eclipse Genie CLA 2018-01-22 04:36:57 EST 
New Gerrit change created: https://git.eclipse.org/r/115793
Comment 6 Andrey Loskutov CLA 2018-01-22 04:45:26 EST 
I've created bug 530117 as follow up.
Comment 7 Eclipse Genie CLA 2018-01-22 07:11:08 EST 
Gerrit change https://git.eclipse.org/r/115793 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=bd89ee55c9defa5b740795c48fe0065aa23073c0
Comment 8 Andrey Loskutov CLA 2018-01-22 07:17:42 EST 
Thanks for reporting this Guillermo!
Comment 9 Andrey Loskutov CLA 2018-01-23 04:29:05 EST 
Verified in I20180122-2000 with JDK 9.0.4 / 1.8_144.