Bug 529789 - Promote Util.isExcluded to CharOperation
Summary: Promote Util.isExcluded to CharOperation
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.8.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-13 06:58 EST by Ed Willink CLA
Modified: 2018-01-13 10:31 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2018-01-13 06:58:03 EST 
org.eclipse.jdt.internal.compiler.util.Util.java has the following comment for isExcluded

	/* TODO (philippe) should consider promoting it to CharOperation

Please do so. I have just taken a copy for use by OCL builder path matching to avoid use of JDT internals.
Comment 1 Andrey Loskutov CLA 2018-01-13 06:59:58 EST 
Ed, do you want to contibute a patch?
Comment 2 Ed Willink CLA 2018-01-13 07:05:14 EST 
(In reply to Andrey Loskutov from comment #1)
> Ed, do you want to contibute a patch?

If you really want, but...

I am not competent to do the "consider" referenced in the comment.
The patch/migration is trivial, apart from
Improving the Javadoc to explain e.g. isFolderPath.
Comment 3 Andrey Loskutov CLA 2018-01-13 10:31:33 EST 
(In reply to Ed Willink from comment #2)
> (In reply to Andrey Loskutov from comment #1)
> > Ed, do you want to contibute a patch?
> 
> If you really want, but...

I honestly never heard about this code before, I guess *you* wanted something to happen.
 
> I am not competent to do the "consider" referenced in the comment.
> The patch/migration is trivial, apart from
> Improving the Javadoc to explain e.g. isFolderPath.

If you care and need this - propose the patch. If it is trivial, even better. Add proper javadoc, fix all references to the old one etc.

---------------------------------------------
спасение утопающих - дело рук самих утопающих
---------------------------------------------