Bug 529589 - "Externalize Strings" wizard: "Widget is disposed" exception on entering duplicate key, breaking wizard
Summary: "Externalize Strings" wizard: "Widget is disposed" exception on entering dupl...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7.2   Edit
Hardware: PC Windows 7
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2018-01-09 11:00 EST by Ralf Pakosch CLA
Modified: 2020-09-09 03:17 EDT (History)
1 user (show)

See Also:


Attachments
Screenshot of wizard after step 5. (99.29 KB, image/png)
2018-01-09 11:00 EST, Ralf Pakosch CLA
no flags Details
Screenshot of wizard on step 7. (104.69 KB, image/png)
2018-01-09 11:01 EST, Ralf Pakosch CLA
no flags Details
I dont get exception (104.21 KB, image/jpeg)
2018-01-09 11:17 EST, Vikas Chandra CLA
no flags Details
Logged error event. (8.29 KB, text/plain)
2018-01-09 11:28 EST, Ralf Pakosch CLA
no flags Details
Logged error events. (23.34 KB, text/plain)
2018-01-09 11:33 EST, Ralf Pakosch CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Pakosch CLA 2018-01-09 11:00:56 EST
Created attachment 272200 [details]
Screenshot of wizard after step 5.

Entering a duplicate key can cause a "Widget is disposed" exception to occur, making the wizard unusable. Already entered keys are lost.

Reproduce:
1) Create a new plug-in project using the "Hello, World Command" template.
2) Click "Plug-In Tools -> Externalize Strings..." on the new project.
3) Expand the plug-in in the wizard and select "plugin.xml [6 instances]".
4) In the "Strings to externalize" table, enter the key "test" in the first row (string "Sample Category").
5) Now enter the same key ("test") in the third row (string "Sample Menu").
6) Click on the key of the fourth row (to enable its cell editor).
7) The exception occurs (not logged, only visible in a dialog).

This is especially bad for plug-ins containing many translatable strings in the plugin.xml file, since the chance of entering a duplicate key is higher and more data is lost when the exception occurs.
Comment 1 Ralf Pakosch CLA 2018-01-09 11:01:34 EST
Created attachment 272201 [details]
Screenshot of wizard on step 7.
Comment 2 Vikas Chandra CLA 2018-01-09 11:17:38 EST
Created attachment 272202 [details]
I dont get exception

What is the build is you are using?
Can you try in a new workspace? Is there something in the step that has to be done to recreate this issue?
Comment 3 Ralf Pakosch CLA 2018-01-09 11:24:21 EST
Comment on attachment 272202 [details]
I dont get exception

I'm using:
Eclipse for RCP and RAP Developers
Version: Oxygen.2 Release (4.7.2)
Build id: 20171218-0600
(Probably not important, but I was using 4.7.1 and upgraded to 4.7.2 by the (new?) automated update mechanism.)

I can also reproduce the problem in a new workspace.
If I set the second key by pressing return, I get the same result as you. It only occurs when you activate the next row's cell editor by clicking on it.
Comment 4 Ralf Pakosch CLA 2018-01-09 11:28:59 EST
Created attachment 272203 [details]
Logged error event.

The error was logged when I reproduced it in the new workspace!
Comment 5 Ralf Pakosch CLA 2018-01-09 11:33:45 EST
Created attachment 272204 [details]
Logged error events.

It appears like three error events are logged each time.
Comment 6 Eclipse Genie CLA 2020-09-08 12:21:01 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 7 Ralf Pakosch CLA 2020-09-09 03:17:36 EDT
I wasn't able to reproduce this problem in Eclipse 2020-06, so it appears to be fixed. Thank you!