Bug 529585 - Remove the "old UI" preference and all related code
Summary: Remove the "old UI" preference and all related code
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 5.1.0   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-01-09 10:44 EST by Pierre-Charles David CLA
Modified: 2021-06-06 12:54 EDT (History)
1 user (show)

See Also:

Attachments
Result of the SWTbot Sequence tests running using the "new" UI (152.17 KB, text/plain)
2018-01-09 10:47 EST, Pierre-Charles David CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Charles David CLA 2018-01-09 10:44:32 EST 
A long time ago, we had a very different "front-end" UI for Sirius based on a "Model Content" view (instead of the Model Explorer) and a global toolbar for actions (instead of the embedded one directly inside diagram editors). This UI is no longer available for users, but we still have some tests which rely on it and activate it programmatically, and thus the corresponding code is still present.

The tests in question are the SWTBot Sequence ones, which all inherit from AbstractSequenceDiagramTestCase where onSetUpAfterOpeningDesignerPerspective() does:

    changeDiagramUIPreference(SiriusDiagramUiPreferencesKeys.PREF_OLD_UI.name(), true);

The goal is to:
* fix the tests to work reliably with the current UI;
* remove this old preference;
* remove all the associated code which is "mostly dead" right now and will be completely dead after the preference is not used anywhere anymore.
Comment 1 Pierre-Charles David CLA 2018-01-09 10:47:16 EST 
Created attachment 272199 [details]
Result of the SWTbot Sequence tests running using the "new" UI