Bug 529245 - Table Renderer Vertical compact vertical mode is broken when embedded into FillLayout
Summary: Table Renderer Vertical compact vertical mode is broken when embedded into Fi...
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: 1.15.0   Edit
Hardware: PC Linux
: P5 normal (vote)
Target Milestone: 1.17.0   Edit
Assignee: Stefan Dirix CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2017-12-27 11:02 EST by Jonas Helming CLA
Modified: 2018-06-14 05:53 EDT (History)
1 user (show)

See Also:

Attachments
screenshot (51.57 KB, image/jpeg)
2017-12-27 11:02 EST, Jonas Helming CLA 		no flags Details
demoProjects (191.08 KB, application/zip)
2017-12-27 11:03 EST, Jonas Helming CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Helming CLA 2017-12-27 11:02:48 EST 
Created attachment 272044 [details]
screenshot

see attached screenshot
Comment 1 Jonas Helming CLA 2017-12-27 11:03:54 EST 
Created attachment 272045 [details]
demoProjects
Comment 2 Eclipse Genie CLA 2018-04-25 13:32:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/121749
Comment 3 Eugen Neufeld CLA 2018-05-16 05:11:09 EDT 
is this planned for the 1.17 release?
Comment 4 Stefan Dirix CLA 2018-05-16 13:12:12 EDT 
REGRESSION INFORMATION

- Summary
The provided fix makes sure that controls rendered in RenderMode.COMPACT_VERTICALLY are properly layouted. Additionally background color inconsistencies were fixed.

- Potential regressions
Previously the GridDescription returned by renderers in RenderMode.COMPACT_VERTICALLY contained only default values. Therefore all composites (label, validation, table) where layouted with equal widths in the default case. This is no longer the case and therefore could cause a regression. Also the background colors of the composites are now set in the same way as when rendered in RenderMode.DEFAULT. Clients which relied on non-set background colors could experience a regression.

- Affected areas / use cases
The affected renderers are MultiReferenceSWTRenderer, TableControlSWTRenderer and MultiAttributeSWTRenderer when rendering in mode RenderMode.COMPACT_VERTICALLY in combination with the default ECPLayoutProvider.

- Things that shall be tested
Check if the forms in which RenderMode.COMPACT_VERTICALLY was used still look the same as before in layout and background color.