Community
Participate
Working Groups
We are using TreeMasterDetail to render our model. We found out that when we remove a child object from a tree then it is not removed from validation context so method: private static Collection<EObject> getAllEObjectsToValidate(EMFFormsSettingToControlMapper controlMapper) from ValidationServiceImpl returns it also. After some debugging we discovered that EMFFormsSettingToControlMapper implementation (which is SettingToControlMapperImpl) has a bug. When child context (for new object in a tree) is added then it adds all control from a view which is renderer but additionally it adds parent control which is a TreeMasterDetail (all is done in method vControlAdded which is executed when child context is added). The problem is that when we remove this child context a method childContextDisposed is executed which removes all controls which are on a view. But it does not remove a parent so it will never remove a setting from settingToControlMap in method deleteOldMapping. Adam
Hi Adam, thank you for the detailed analysis. Would you be interested to provide a fix for this? Cheers, Eugen
Hi Eugen Can you tell me shortly how to provide a fix? Which repo should I clone etc.? I did one fix already but it was a long time ago. Adam
Hi Adam, just clone git://git.eclipse.org/gitroot/emfclient/org.eclipse.emf.ecp.core.git switch to the develop branch and do a gerrit contribution. Cheers, Eugen
Hi Eugen, I want to prepare a fix for it. I followed the installation of IDE which is described here: https://www.eclipse.org/ecp/emfforms/gettinginvolved.html However, IDE is not starting. There is no error, log etc. Are these steps correctly described? Adam
Problem with IDE fixed.
Hi Eugen, I cannot get imported projects compiled without errors. After import I have about 1000 compilation errors. I changed target platform, set severity of restriction rules to JavaFX to Warning. But still projects are missing some plugins, some types etc. How to fix it. I cloned and imported whole repository. Adam
Hi Adam, did you follow the guide here: https://www.eclipse.org/ecp/emfforms/gettinginvolved.html Otherwise just close all projects containing "rap" or "javafx" in their name. Also set the "ecp.target". Cheers, Eugen
Hi Eugen I have a fix for it but how can I test it? How can I run TreeMasterDetail example? Adam
Hi Adam, the easiest thing to do would be to use the MakeItHappen Example. Just modify the ViewModel and run the example using the product from the IDE. Cheers, Eugen
New Gerrit change created: https://git.eclipse.org/r/114732
Hi Eugen, I provided a fix for it. Should I do something more or just wait for the review? Adam
Hi Adam, I will do the review in the next couple of days. Cheers, Eugen
New Gerrit change created: https://git.eclipse.org/r/120064
New Gerrit change created: https://git.eclipse.org/r/120063
Gerrit change https://git.eclipse.org/r/120063 was merged to [develop]. Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=61df557dedb47cf0b0588bc087ddcf0dcd7108ca
Gerrit change https://git.eclipse.org/r/120064 was merged to [develop]. Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=42e848bfa2bc8cf2c75205a32bd8900183d0161a
This caused a regression, fixed with https://bugs.eclipse.org/bugs/show_bug.cgi?id=533620
