Bug 528448 - Git page stash/patch/delete/commit buttons have unnatural tab order
Summary: Git page stash/patch/delete/commit buttons have unnatural tab order
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 17.0   Edit
Assignee: Carolyn MacLeod CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2017-12-11 14:02 EST by Carolyn MacLeod CLA
Modified: 2017-12-11 14:20 EST (History)
0 users

See Also:

Attachments
unnatural-tab-order.PNG (9.53 KB, image/png)
2017-12-11 14:02 EST, Carolyn MacLeod CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2017-12-11 14:02:02 EST 
Created attachment 271854 [details]
unnatural-tab-order.PNG

The stash, patch, delete, and commit buttons on the git page should have a natural tab order (which would be from left to right). They currently go from the centre to the right, and then from left to center (see snapshot).
Comment 1 Eclipse Genie CLA 2017-12-11 14:10:41 EST 
GitHub Pull Request 287 created by [carmacleod]
https://github.com/eclipse/orion.client/pull/287
Comment 2 Carolyn MacLeod CLA 2017-12-11 14:20:15 EST 
Fixed with PR in comment 1.

Fix was to reorder the selectionArea and actionArea toolbars logically in the DOM in "section.js".

Also made a couple other accessibility-related changes in section.js:
- orionSections now have a parent for the wrapper and table siblings (was originally just the two siblings)
- allow expand/collapse with space key (not just enter)
- mark up (non dropdown) orionSections as landmark region