Bug 527998 - 'Class File Viewer' and 'Module-Info Class File Viewer' registered twice as editor
Summary: 'Class File Viewer' and 'Module-Info Class File Viewer' registered twice as e...
Status: CLOSED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2017-12-01 03:52 EST by Andreas Sewe CLA
Modified: 2020-05-08 12:33 EDT (History)
1 user (show)

See Also:


Attachments
Screenshot illustrating the situation (112.98 KB, image/png)
2017-12-01 03:52 EST, Andreas Sewe CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sewe CLA 2017-12-01 03:52:01 EST
Created attachment 271726 [details]
Screenshot illustrating the situation

Just noticed this when testing the Oxygen.2 RC3 Java EPP package:

The Editor Selection dialog (Open With > Other...) shows *two* seemingly identical entries of

  Class File Viewer

and

  Module-Info Class File Viewer

(See the attached screenshot)

This is confusing.
Comment 1 Andreas Sewe CLA 2017-12-01 03:55:56 EST
FWIW, its also possible to add *both* "Class File Viewer"s to the General > Editor > File Associations of "*.class without source". Likewise for module-info.class and the "Module-Info Class File Viewer"s.
Comment 2 Dani Megert CLA 2017-12-01 09:29:49 EST
They are registered for different content types. We could use different names though.

Not that important since it is really the same editor.
Comment 3 Andreas Sewe CLA 2017-12-01 10:09:01 EST
(In reply to Dani Megert from comment #2)
> They are registered for different content types. We could use different
> names though.
> 
> Not that important since it is really the same editor.

I'm not sure whether this would alleviate the user's confusion. Then they would have to pick between two seemingly different editors.

I think the problem is that they see a choice where there really is none. So, I wonder whether the two entries couldn't be merged automatically.
Comment 4 Dani Megert CLA 2017-12-01 10:10:21 EST
(In reply to Andreas Sewe from comment #3)
> (In reply to Dani Megert from comment #2)
> > They are registered for different content types. We could use different
> > names though.
> > 
> > Not that important since it is really the same editor.
> 
> I'm not sure whether this would alleviate the user's confusion. Then they
> would have to pick between two seemingly different editors.
> 
> I think the problem is that they see a choice where there really is none.
> So, I wonder whether the two entries couldn't be merged automatically.

This is there since more than 10 years, so...
Comment 5 Dani Megert CLA 2017-12-01 10:11:30 EST
(In reply to Andreas Sewe from comment #3)
> I think the problem is that they see a choice where there really is none.
> So, I wonder whether the two entries couldn't be merged automatically.

Patches welcome ;-)
Comment 6 Dani Megert CLA 2017-12-18 09:58:51 EST
This can probably be fixed very easily by just combining the two extensions into one.
Comment 7 Eclipse Genie CLA 2020-05-08 12:33:10 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.