Bug 527846 - "Export as Image" dialog should be defined outside of the core.
Summary: "Export as Image" dialog should be defined outside of the core.
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-11-28 03:44 EST by Jessy Mallet CLA
Modified: 2017-11-28 05:18 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessy Mallet CLA 2017-11-28 03:44:55 EST 
The "Export as Image" dialog is defined in the core org.eclipse.sirius.ui plug-in, so it can not access to the SiriusDiagramUiPreferencesKeys stored in org.eclipse.sirius.diagram.ui.

These preferences impact the initialization of export dialog (for example PREF_SCALE_DIAGRAMS_ON_EXPORT preference).
So the "Export as Image" dialog must not be defined org.eclipse.sirius.ui but rather in org.eclipse.sirius.diagram.ui.

For now, to bypassing this constraint, we use the IDialogSetting to tell it the value of the preference (see org.eclipse.sirius.diagram.ui.provider.DiagramUIPlugin class) but if default value are overridden, the new value is not propagate to the export dialog via the change listener.