Bug 527691 - Edit Launch Configuration dialog needs accessibility work
Summary: Edit Launch Configuration dialog needs accessibility work
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 17.0   Edit
Assignee: Carolyn MacLeod CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2017-11-23 14:03 EST by Carolyn MacLeod CLA
Modified: 2017-11-29 22:13 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2017-11-23 14:03:42 EST 
- labels on each wizard page need to be semantically connected to fields
- needs role=dialog aria-labelledby=dialog-title-id
- needs initial focus set into the dialog
- return focus to logical place on close
Comment 1 Carolyn MacLeod CLA 2017-11-29 21:28:56 EST 
Also:
- dialog needs aria-modal=true
- table element used for layout needs role=presentation
- shouldn't be able to drag dialog when clicking on close box
- shouldn't have hover style on save/next/prev buttons when they are disabled
- save button is wrong color for light theme
Comment 2 Eclipse Genie CLA 2017-11-29 22:12:20 EST 
GitHub Pull Request 281 created by [carmacleod]
https://github.com/eclipse/orion.client/pull/281
Comment 3 Carolyn MacLeod CLA 2017-11-29 22:13:51 EST 
Fixed by PR in comment 2.