Bug 527408 - 2 different conflicting configurations of code generator
Summary: 2 different conflicting configurations of code generator
Status: NEW
Alias: None
Product: Lyo
Classification: Technology
Component: Tools (show other bugs)
Version: 2.2.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 2.x.x   Edit
Assignee: Jad El-khoury CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-17 09:47 EST by Jad El-khoury CLA
Modified: 2017-11-30 17:09 EST (History)
2 users (show)

See Also:


Attachments
A meny item that should not be visible in the context meny of a Adaptor (31.73 KB, image/png)
2017-11-30 17:09 EST, Jad El-khoury CLA
no flags Details
A meny item that should not be visible in the context meny of a Domain Specification (31.73 KB, image/png)
2017-11-30 17:09 EST, Jad El-khoury CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jad El-khoury CLA 2017-11-17 09:47:18 EST
Since it is possible to generate code per adaptor (bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=521222), there are now two different ways of generating code, which result in code being produced in 2 different locations.

1. Generation of whole toolchain based on the tools.codegenerator.ui plugin. This generates code assuming the base path of the eclipse project where the model resides.

2. Generation of each adaptor based on a context meny item defined in the Sirius model. In this geenration, the user is prompted for the base path.

Make sure these 2 generation approaches are consistent in behaviour for the user.
Comment 1 Eclipse Genie CLA 2017-11-17 09:49:37 EST
New Gerrit change created: https://git.eclipse.org/r/111804
Comment 2 Yash Khatri CLA 2017-11-24 05:16:49 EST
/org.eclipse.lyo.tools.codegenerator.ui/plugin.xml

Has two problems:

1) org.eclipse.ui.popupMenus is deprecated
2) objectContribution (should be menuContribution) needs a child Visibility
Comment 3 Jad El-khoury CLA 2017-11-24 05:20:23 EST
(In reply to Yash Khatri from comment #2)
> /org.eclipse.lyo.tools.codegenerator.ui/plugin.xml
> 
> Has two problems:
> 
> 1) org.eclipse.ui.popupMenus is deprecated
> 2) objectContribution (should be menuContribution) needs a child Visibility

Are these problems due to teh new change, or have they existed before? because the plugin has been working before.
Comment 5 Jad El-khoury CLA 2017-11-30 17:09:16 EST
Created attachment 271722 [details]
A meny item that should not be visible in the context meny of a Adaptor

A meny item that should not be visible in the context meny of a Adaptor
Comment 6 Jad El-khoury CLA 2017-11-30 17:09:41 EST
Created attachment 271723 [details]
A meny item that should not be visible in the context meny of a Domain Specification

A meny item that should not be visible in the context meny of a Domain Specification.
It just does not make sense.