Bug 527082 - [hovering][preferences] Add "Popup" as search term to Hovers preference page
Summary: [hovering][preferences] Add "Popup" as search term to Hovers preference page
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M4   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-09 14:50 EST by Lars Vogel CLA
Modified: 2017-11-30 11:28 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2017-11-09 14:50:09 EST
The super annoying "Combined Hover" popup is really hard to find in the preferences. I suggest adding the search word "Popup" to this preference page.
Comment 1 Lars Vogel CLA 2017-11-09 14:54:04 EST
Noopur, are you OK with adding the word as search term for the preference page?
Comment 2 Noopur Gupta CLA 2017-11-10 01:19:37 EST
We already have "hover", "combined" etc. as the search terms. I am also fine with adding "popup" as a new search term for this page.
Comment 3 Dani Megert CLA 2017-11-10 06:13:57 EST
(In reply to Lars Vogel from comment #0)
> The super annoying "Combined Hover"

What's annoying with that? I like it.


Note that "popup" is not a correct word. Correct is "pop-up".

If we add it, it also has to be added to the 'Text Editors' page
Comment 4 Lars Vogel CLA 2017-11-10 08:17:38 EST
(In reply to Dani Megert from comment #3)
> (In reply to Lars Vogel from comment #0)
> > The super annoying "Combined Hover"
> 
> What's annoying with that? I like it.

See Stackoverflow for user opinions which hates it:

https://stackoverflow.com/questions/4072835/how-to-disable-annoying-eclipse-tag-descriptions-on-hover
http://www.eclipseonetips.com/2010/08/24/configure-tooltips-in-eclipse-to-only-popup-on-request/
Comment 5 Lars Vogel CLA 2017-11-10 08:18:48 EST
(In reply to Dani Megert from comment #3 
> Note that "popup" is not a correct word. Correct is "pop-up".

In this case it would be useful to add both, so that users which use "popup" (see Stackoverflow posts for the language our users use) still find it.
Comment 6 Dani Megert CLA 2017-11-10 08:22:16 EST
(In reply to Lars Vogel from comment #4)
> (In reply to Dani Megert from comment #3)
> > (In reply to Lars Vogel from comment #0)
> > > The super annoying "Combined Hover"
> > 
> > What's annoying with that? I like it.
> 
> See Stackoverflow for user opinions which hates it:


I asked *you*.


> https://stackoverflow.com/questions/4072835/how-to-disable-annoying-eclipse-tag-descriptions-on-hover
> 
> http://www.eclipseonetips.com/2010/08/24/configure-tooltips-in-eclipse-to-only-popup-on-request/

This is more talking about hovers in general and not the combined one. Or did I miss something?
Comment 7 Noopur Gupta CLA 2017-11-10 08:48:46 EST
(In reply to Lars Vogel from comment #5)
> (In reply to Dani Megert from comment #3 
> > Note that "popup" is not a correct word. Correct is "pop-up".
> 
> In this case it would be useful to add both, so that users which use "popup"
> (see Stackoverflow posts for the language our users use) still find it.

+1 to add both.

Lars, would you like to provide a patch?

Also, note the following:

(In reply to Dani Megert from comment #3)
> If we add it, it also has to be added to the 'Text Editors' page
Comment 8 Lars Vogel CLA 2017-11-10 09:52:54 EST
> I asked *you*

I hate it for the same reasons.
Comment 9 Dani Megert CLA 2017-11-10 09:56:59 EST
(In reply to Lars Vogel from comment #8)
> > I asked *you*
> 
> I hate it for the same reasons.

So, you don't like hovers in the editor? That's the only argument I saw there.
Comment 10 Lars Vogel CLA 2017-11-10 10:18:15 EST
t(In reply to Dani Megert from comment #9)
> (In reply to Lars Vogel from comment #8)
> > > I asked *you*
> > 
> > I hate it for the same reasons.
> 
> So, you don't like hovers in the editor? That's the only argument I saw
> there.

Yes, I dislike automatic popups blocking the code I'm looking/working at/on.
Comment 11 Lars Vogel CLA 2017-11-27 11:19:01 EST
(In reply to Noopur Gupta from comment #7)
> +1 to add both.

Looks to me that currently special signs like "-" in pop-up cannot be used a search term. I open a bug for this.

> Lars, would you like to provide a patch?
Yes, as special signs are currently not supported, I add "popup" as first step.

> (In reply to Dani Megert from comment #3)
> > If we add it, it also has to be added to the 'Text Editors' page

Looks like this is in eclipse.platform.text.
Comment 12 Eclipse Genie CLA 2017-11-27 14:04:43 EST
New Gerrit change created: https://git.eclipse.org/r/112344
Comment 13 Eclipse Genie CLA 2017-11-27 14:04:47 EST
New Gerrit change created: https://git.eclipse.org/r/112343
Comment 15 Noopur Gupta CLA 2017-11-28 03:14:52 EST
Thanks, Lars.

(In reply to Eclipse Genie from comment #13)
> New Gerrit change created: https://git.eclipse.org/r/112343
Released with:
http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=3fbfd3dcd67ff10b21d8a19ebbe92cc0cb5ea951

"pop-up" can be added after bug 527833 is fixed.
Comment 16 Lars Vogel CLA 2017-11-28 03:42:25 EST
Thanks Noopur, that was the fast JDT UI review I ever experience.
Comment 17 Dani Megert CLA 2017-11-28 05:55:01 EST
(In reply to Lars Vogel from comment #11)
> (In reply to Noopur Gupta from comment #7)
> > +1 to add both.
> 
> Looks to me that currently special signs like "-" in pop-up cannot be used a
> search term. I open a bug for this.

This works fine for me.
Comment 18 Dani Megert CLA 2017-11-28 05:58:08 EST
.
Comment 19 Noopur Gupta CLA 2017-11-28 07:50:00 EST
(In reply to Dani Megert from comment #17)
> > Looks to me that currently special signs like "-" in pop-up cannot be used a
> > search term. I open a bug for this.
> 
> This works fine for me.
It doesn't work for me. Adding "pop-up" as a search term doesn't find the page. Anything else needs to be done?
Comment 20 Dani Megert CLA 2017-11-30 07:25:46 EST
(In reply to Noopur Gupta from comment #19)
> (In reply to Dani Megert from comment #17)
> > > Looks to me that currently special signs like "-" in pop-up cannot be used a
> > > search term. I open a bug for this.
> > 
> > This works fine for me.
> It doesn't work for me. Adding "pop-up" as a search term doesn't find the
> page. Anything else needs to be done?

Very strange. Just tried again in org.eclipse.jdt.ui/plugin.properties:
preferenceKeywords.hover=pop-up Java editor .....
and it works just fine for me.
Comment 21 Lars Vogel CLA 2017-11-30 07:29:44 EST
(In reply to Dani Megert from comment #20)
> Very strange. Just tried again in org.eclipse.jdt.ui/plugin.properties:
> preferenceKeywords.hover=pop-up Java editor .....
> and it works just fine for me.

I did add it behind "hover", maybe this makes a difference?
Can you push your local change to Gerrit so that I can try it out?
Comment 22 Dani Megert CLA 2017-11-30 09:09:41 EST
(In reply to Lars Vogel from comment #21)
> (In reply to Dani Megert from comment #20)
> > Very strange. Just tried again in org.eclipse.jdt.ui/plugin.properties:
> > preferenceKeywords.hover=pop-up Java editor .....
> > and it works just fine for me.
> 
> I did add it behind "hover", maybe this makes a difference?
> Can you push your local change to Gerrit so that I can try it out?

It's faster for both of us to just do it in the code. If the location of the keyword matters, then we have to reopen your bug.
Comment 23 Lars Vogel CLA 2017-11-30 09:20:54 EST
(In reply to Dani Megert from comment #22)
> It's faster for both of us to just do it in the code. If the location of the
> keyword matters, then we have to reopen your bug.

I disagree, you have a working solution, while Noopur and I failed to set it up. Sharing this solution is faster then leaving it to us to guess what else you did.
Comment 24 Lars Vogel CLA 2017-11-30 09:28:00 EST
Tested with "pop-up" at the first word, works for me. Silly, silly, IT.

Noopur, do you want a patch for adding it at the beginning or shall we wait for a more general solution in which "-" can be used everywhere?
Comment 25 Dani Megert CLA 2017-11-30 09:43:54 EST
(In reply to Lars Vogel from comment #24)
> Tested with "pop-up" at the first word, works for me. Silly, silly, IT.

I wonder how this was programmed :-).


> Noopur, do you want a patch for adding it at the beginning or shall we wait
> for a more general solution in which "-" can be used everywhere?

Please provide a patch and reopen your bug.
Comment 26 Noopur Gupta CLA 2017-11-30 09:44:50 EST
(In reply to Lars Vogel from comment #24)
> Tested with "pop-up" at the first word, works for me. Silly, silly, IT.
> 
> Noopur, do you want a patch for adding it at the beginning or shall we wait
> for a more general solution in which "-" can be used everywhere?

Does it work like this for the 'Text Editors' page also? If so, we can release both the fixes by adding it to the beginning now so that users can work with it. Also, we should reopen the Platform Text bug for the general fix.
Comment 27 Eclipse Genie CLA 2017-11-30 10:27:13 EST
New Gerrit change created: https://git.eclipse.org/r/112642
Comment 29 Eclipse Genie CLA 2017-11-30 10:52:42 EST
New Gerrit change created: https://git.eclipse.org/r/112647
Comment 30 Lars Vogel CLA 2017-11-30 10:54:24 EST
(In reply to Noopur Gupta from comment #26)
> Does it work like this for the 'Text Editors' page also? 

Works for me. I uploaded a patch for the text repo, in case you want to try it.
Comment 31 Lars Vogel CLA 2017-11-30 11:28:01 EST
Thanks Dani and Noopur for the reviews.