Bug 526884 - Depth-first traversal algorithm bring stack overflow during layout process for large-scale diagram
Summary: Depth-first traversal algorithm bring stack overflow during layout process fo...
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-11-06 07:55 EST by mind calm CLA
Modified: 2017-11-17 05:05 EST (History)
2 users (show)

See Also:

Attachments
the model is f20k.family (113.55 KB, application/octet-stream)
2017-11-06 07:55 EST, mind calm CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mind calm CLA 2017-11-06 07:55:31 EST 
Created attachment 271343 [details]
the model is f20k.family

Hi,

When i test a large-scale model, i was trying to create the diagram and open it, i met the problem as in attachment.
Comment 1 mind calm CLA 2017-11-06 19:55:52 EST 
Caused by: java.lang.StackOverflowError
	at org.eclipse.sirius.diagram.ui.tools.internal.layout.AutoSizeAndRegionAwareGraphLayout.recursiveHandleVirtualNode(AutoSizeAndRegionAwareGraphLayout.java:307)
	at org.eclipse.sirius.diagram.ui.tools.internal.layout.AutoSizeAndRegionAwareGraphLayout.recursiveHandleVirtualNode(AutoSizeAndRegionAwareGraphLayout.java:347)
	at org.eclipse.sirius.diagram.ui.tools.internal.layout.AutoSizeAndRegionAwareGraphLayout.recursiveHandleVirtualNode(AutoSizeAndRegionAwareGraphLayout.java:352)
	at org.eclipse.sirius.diagram.ui.tools.internal.layout.AutoSizeAndRegionAwareGraphLayout.recursiveHandleVirtualNode(AutoSizeAndRegionAwareGraphLayout.java:347)
	at org.eclipse.sirius.diagram.ui.tools.internal.layout.AutoSizeAndRegionAwareGraphLayout.recursiveHandleVirtualNode(AutoSizeAndRegionAwareGraphLayout.java:352)
	at org.eclipse.sirius.diagram.ui.tools.internal.layout.AutoSizeAndRegionAwareGraphLayout.recursiveHandleVirtualNode(AutoSizeAndRegionAwareGraphLayout.java:347)
	at org.eclipse.sirius.diagram.ui.tools.internal.layout.AutoSizeAndRegionAwareGraphLayout.recursiveHandleVirtualNode(AutoSizeAndRegionAwareGraphLayout.java:352)
******************************************************************************
Comment 2 Pierre-Charles David CLA 2017-11-07 05:23:59 EST 
See also https://www.eclipse.org/forums/index.php/mv/msg/1088968/1775840/ for the original discussion.
Comment 3 mind calm CLA 2017-11-07 20:28:26 EST 
Hi, Pierre-Charles

yes, you told me "the code originally lifted from GMF Runtime (CompositeDirectedGraphLayout) to add some customizations", and you asked me to open a bugzilla for this with more details about "large-scale model".
Comment 4 Pierre-Charles David CLA 2017-11-08 02:57:27 EST 
I remember, I'm just adding the link so that when we tackle this issue we can easily get the full context, including the exchange with Ed Willink.