Bug 526085 - [NPE] Problems with 8 bit characters in filenames
Summary: [NPE] Problems with 8 bit characters in filenames
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 4.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-16 10:24 EDT by Jens Seidel CLA
Modified: 2018-04-09 12:33 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Seidel CLA 2017-10-16 10:24:18 EDT
I have a file which name is latin1 encoded. This file shows as added and deleted and also stashing fails.

Is there no support for 8 bit characters yet? I read about problems on Mac because of decomposed unicode characters but I have here only a latin1 string.

Now I even got a null pointer exception:

eclipse.buildId=4.7.1.M20171009-0410
java.version=1.8.0_141
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=de_DE
Framework arguments:  -product org.eclipse.epp.package.cpp.product
Command-line arguments:  -data file:/home/jens/.eclipse/workspace/ -os linux -ws gtk -arch x86_64 -product org.eclipse.epp.package.cpp.product

org.eclipse.core.jobs
Error
Mon Oct 16 15:43:53 CEST 2017
An internal error occurred during: "Initializing Compare Editor for einstechfräsen.pptx".

java.lang.NullPointerException
	at org.eclipse.egit.ui.internal.CompareUtils.getFileRevisionTypedElement(CompareUtils.java:143)
	at org.eclipse.egit.ui.internal.synchronize.compare.GitCompareInput.getLeft(GitCompareInput.java:122)
	at org.eclipse.egit.ui.internal.synchronize.model.GitModelBlob.prepareTypedElements(GitModelBlob.java:279)
	at org.eclipse.egit.ui.internal.synchronize.model.GitModelBlob.getLeft(GitModelBlob.java:153)
	at org.eclipse.team.internal.ui.mapping.ModelCompareEditorInput.isLeftEditable(ModelCompareEditorInput.java:321)
	at org.eclipse.team.internal.ui.mapping.ModelCompareEditorInput.prepareCompareInput(ModelCompareEditorInput.java:122)
	at org.eclipse.team.ui.synchronize.SaveableCompareEditorInput.prepareInput(SaveableCompareEditorInput.java:278)
	at org.eclipse.compare.CompareEditorInput.run(CompareEditorInput.java:485)
	at org.eclipse.compare.internal.CompareUIPlugin.prepareInput(CompareUIPlugin.java:604)
	at org.eclipse.compare.internal.CompareEditor$1.run(CompareEditor.java:331)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)

PS: There was also an attempt by the automatic error reporting tool to report this but it failed with an network error (proxy problems?). I do not know where a local copy of this report is saved. This report contained a few more information. If anything is missing, just contact me ...
Comment 1 Thomas Wolf CLA 2017-10-16 18:02:27 EDT
AERI https://dev.eclipse.org/recommenders/committers/aeri/v2/#!/problems/5819e186e4b0e07e5bc299af might be related.

Can you check for any exception in <workspace>/.metadata/.log or <workspace>/.metadata/.bak_X.log, please? If there's anything in there looking like

  java.lang.RuntimeException: Unencodable file: einstechfr?sen.pptx
    at org.eclipse.jgit.treewalk.WorkingTreeIterator$Entry.encodeName

then it's definitely the same as that automated error report.
Comment 2 Jens Seidel CLA 2017-10-17 05:16:11 EDT
(In reply to Thomas Wolf from comment #1)
> Can you check for any exception in <workspace>/.metadata/.log or
> <workspace>/.metadata/.bak_X.log, please? If there's anything in there
> looking like
> 
>   java.lang.RuntimeException: Unencodable file: einstechfr?sen.pptx
>     at org.eclipse.jgit.treewalk.WorkingTreeIterator$Entry.encodeName
> 
> then it's definitely the same as that automated error report.

I do not have such an entry in my .log file. What I have are other similar problems related to my file:

!ENTRY org.eclipse.egit.ui 4 0 2017-10-16 15:24:15.064
!MESSAGE Stash create error
!STACK 1
org.eclipse.team.core.TeamException: Stashing local changes did not successfully complete
        at org.eclipse.egit.core.op.StashCreateOperation$1.run(StashCreateOperation.java:97)
        at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2240)
        at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2267)
        at org.eclipse.egit.core.op.StashCreateOperation.execute(StashCreateOperation.java:109)
        at org.eclipse.egit.ui.internal.stash.StashCreateUI$1.runInWorkspace(StashCreateUI.java:79)
        at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:39)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
Caused by: java.io.FileNotFoundException: <hidden path>/einstechfr�sen.pptx (Datei oder Verzeichnis nicht gefunden)
(translation: file or directory not found)
        at java.io.FileInputStream.open0(Native Method)
        at java.io.FileInputStream.open(FileInputStream.java:195)
        at java.io.FileInputStream.<init>(FileInputStream.java:138)
        at org.eclipse.jgit.treewalk.FileTreeIterator$FileEntry.openInputStream(FileTreeIterator.java:396)
        at org.eclipse.jgit.treewalk.WorkingTreeIterator.getEntryContentLength(WorkingTreeIterator.java:578)
        at org.eclipse.jgit.api.StashCreateCommand.call(StashCreateCommand.java:296)
        at org.eclipse.egit.core.op.StashCreateOperation$1.run(StashCreateOperation.java:95)
        ... 6 more


!SUBENTRY 1 org.eclipse.team.core 4 0 2017-10-16 15:24:15.150
!MESSAGE Stashing local changes did not successfully complete
!STACK 0
java.io.FileNotFoundException: <hidden path>/einstechfr�sen.pptx (Datei oder Verzeichnis nicht gefunden)
(translation: file or directory not found)
        at java.io.FileInputStream.open0(Native Method)
        at java.io.FileInputStream.open(FileInputStream.java:195)
        at java.io.FileInputStream.<init>(FileInputStream.java:138)
        at org.eclipse.jgit.treewalk.FileTreeIterator$FileEntry.openInputStream(FileTreeIterator.java:396)
        at org.eclipse.jgit.treewalk.WorkingTreeIterator.getEntryContentLength(WorkingTreeIterator.java:578)
        at org.eclipse.jgit.api.StashCreateCommand.call(StashCreateCommand.java:296)
        at org.eclipse.egit.core.op.StashCreateOperation$1.run(StashCreateOperation.java:95)
        at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2240)
        at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2267)
        at org.eclipse.egit.core.op.StashCreateOperation.execute(StashCreateOperation.java:109)
        at org.eclipse.egit.ui.internal.stash.StashCreateUI$1.runInWorkspace(StashCreateUI.java:79)
        at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:39)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)