Bug 525825 - crit path bug: swapper special case
Summary: crit path bug: swapper special case
Status: NEW
Alias: None
Product: Tracecompass
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Project Inbox CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-10 11:50 EDT by Genevieve Bastien CLA
Modified: 2017-10-11 09:17 EDT (History)
2 users (show)

See Also:


Attachments
Screenshot that shows the swapper issue (106.67 KB, image/png)
2017-10-10 19:37 EDT, Abderrahmane Benbachir CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Genevieve Bastien CLA 2017-10-10 11:50:16 EDT
The swapper (idle process) is often part of a critical path. But it makes no sense, as the critical path is supposed to be the path that we can shorten to improve the performance of the thread. There's probably another path that was not picked up by the algorithm that is more critical.

So the algorithm should be made to ignore the special swapper process. Or else there may be something missing in the trace to make a good choice. In which case, the user should be warned, because putting swapper in the critical path is confusing.
Comment 1 Matthew Khouzam CLA 2017-10-10 11:55:47 EDT
To be clear, the swapper can be part of the critical path if we have ran out of ram and are using the virtual mem, no?
Comment 2 Genevieve Bastien CLA 2017-10-10 12:24:14 EDT
I don't know, but if so, that should be made clear that memory ran out at this point, which still makes swapper a special case.
Comment 3 Matthew Khouzam CLA 2017-10-10 12:58:09 EDT
I would say swapper is a special case with the Linux kernel since we know what it does... In this case we would need a supplemental swapper analysis to complement the trace. We can just dummy it out, but I think if we do that, we should have the option of bringing it back.
Comment 4 Abderrahmane Benbachir CLA 2017-10-10 13:56:08 EDT
@Mathew I have a patch for that, enabled/disabled is coming too
Comment 5 Abderrahmane Benbachir CLA 2017-10-10 19:37:46 EDT
Created attachment 270921 [details]
Screenshot that shows the swapper issue
Comment 6 Matthew Khouzam CLA 2017-10-11 09:17:12 EDT
Ok, I have  couple of questions:

1- would it be more interesting to sort the entries by coupling like the optimize button?
2- would it be more interesting to have a "filter" option that can remove all processes you don't like?