525250 – "Create local variable" quick fix incorrectly offered outside of local scopes

Bug 525250 - "Create local variable" quick fix incorrectly offered outside of local scopes

Summary: "Create local variable" quick fix incorrectly offered outside of local scopes

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-codan (show other bugs)
Version:	Next
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	9.5.0
Assignee:	Felix Morgner
QA Contact:	Elena Laskavaia

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	537272
	Show dependency tree

Reported:	2017-09-26 17:39 EDT by Nathan Ridge
Modified:	2018-07-24 02:17 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nathan Ridge

2017-09-26 17:39:52 EDT

Given the following code at global scope:

int global = undefined;  // Error: Symbol "undefined" could not be resolved

Codan offers the "create local variable" quick fix for this error, but when it's invoked, nothing happens.

Given that we're not in a local scope and therefore cannot create a local variable, the quick fix shouldn't be offered to begin with.

Comment 1 Eclipse Genie

2018-03-07 11:51:24 EST

New Gerrit change created: https://git.eclipse.org/r/118915

Comment 2 Eclipse Genie

2018-03-14 11:07:51 EDT

Gerrit change https://git.eclipse.org/r/118915 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=47ceed3cbe729626bdf4138a03e518328bfc1c0d

Comment 3 Nathan Ridge

2018-03-14 11:12:21 EDT

Thanks for the fix, Felix!