Community
Participate
Working Groups
When using ‘Save All’ command with both an ActivityExplorer editor and a Sirius Diagram editor opened may result in a parallel saves. This is mainly problematic when custom actions are made during save because in that case they happen twice. When calling this action on an open Sirius Editor the method “SessionSaveable.doSave(IProgressMonitor,IShellProvider)” is called resulting in the creation of a “SaveSessionRunnable” which is scheduled as a background job. On the ActivityExplorer editor the method “SessionSaveable.doSave(IProgressMonitor)” is called and the save action is done in the current thread. It results in having 2 save operations in parallel. The best fix I can think of it by aligning the save behavior of the ActivityExplorer editor to a Sirius representation editor. To do so, the activity explorer has to implements the ISaveableSource interface. It means that saves we will be done in a background job as in Sirius. Using this implementation Eclipse is able to detect that both editors are doing the same save operation and execute only one.
New Gerrit change created: https://git.eclipse.org/r/105595
Gerrit change https://git.eclipse.org/r/105595 was merged to [master]. Commit: http://git.eclipse.org/c/amalgam/org.eclipse.amalgam.git/commit/?id=fa26a0ea1f91e0201f71d5a440c36ea8121de5d3
New Gerrit change created: https://git.eclipse.org/r/105610
Gerrit change https://git.eclipse.org/r/105610 was merged to [v1.9.x]. Commit: http://git.eclipse.org/c/amalgam/org.eclipse.amalgam.git/commit/?id=6128bf3114a006c059a47ab81fa92318d36abcc4
In which version of Amalgam is this issue fixed?
New Gerrit change created: https://git.eclipse.org/r/109907
Gerrit change https://git.eclipse.org/r/109907 was merged to [v1.9.x]. Commit: http://git.eclipse.org/c/amalgam/org.eclipse.amalgam.git/commit/?id=a0fb6293a96eb415d10ceee768db97f04124032a
Also, the implementation of ActivityExplorerEditor.doSave(IProgressMonitor) method must be removed because ActivityExplorerEditor implements ISaveablesSource. All saves will go through the ISaveablesSource / Saveable protocol (like org.eclipse.ui.navigator.CommonNavigator.doSave(IProgressMonitor)).
New Gerrit change created: https://git.eclipse.org/r/110186
Gerrit change https://git.eclipse.org/r/110186 was merged to [v1.9.x]. Commit: http://git.eclipse.org/c/amalgam/org.eclipse.amalgam.git/commit/?id=4d2409dedf26f001b6c76553b6da359c933a522d
New Gerrit change created: https://git.eclipse.org/r/110208
Gerrit change https://git.eclipse.org/r/110208 was merged to [master]. Commit: http://git.eclipse.org/c/amalgam/org.eclipse.amalgam.git/commit/?id=a08a66db922685b5c3b69230a130c6f25a80f129
New Gerrit change created: https://git.eclipse.org/r/117426
Gerrit change https://git.eclipse.org/r/117426 was merged to [v1.8.x]. Commit: http://git.eclipse.org/c/amalgam/org.eclipse.amalgam.git/commit/?id=8f44666338440db168c21cfeb4f122d522eb8336