Bug 522549 - Should be able to type F3 to go to i18n! file
Summary: Should be able to type F3 to go to i18n! file
Status: NEW
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, triaged
Depends on:
Blocks:
 
Reported: 2017-09-20 20:40 EDT by Carolyn MacLeod CLA
Modified: 2017-10-10 09:46 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2017-09-20 20:40:21 EDT 
Open file ThemeBuilder.js in the editor.

Hover over any of the require files to get a tooltip containing a link...
	define(['i18n!orion/settings/nls/messages',
		'orion/i18nUtil',
		'orion/commands', 
		'orion/commandRegistry', 
		'orion/webui/littlelib', 
		'orion/webui/tooltip',
		'orion/widgets/themes/colors',
		'orion/util',
	],
...and click the link to open the file.

Go back to ThemeBuilder.js and use the arrow keys to move the caret into any of the required files except for the messages file in the i18n! bundle.
Type F3 to open the file.

Now use arrows to move the caret up to the messages file in the i18n! bundle.
Type F3.
"Could not find declaration".

This should have opened the appropriate messages.js file.
If it works for the mouse, it should work for the keyboard.
Comment 1 Michael Rennie CLA 2017-10-10 09:46:55 EDT 
Bug 448095 and this bug would be fixed with the same code - the underlying problem is that we don't have the "smarts" to related the actual file containing the strings with the file you reference in-code.

For example, if we provided our strings directly in the root NLS file, this would all work now, but since we use the {root:true} scheme (from requirejs) we lack the logic to find the actual NLS file the same way requirejs does.