521937 – Wrong drop location from model explorer to diagram with negative origin

Bug 521937 - Wrong drop location from model explorer to diagram with negative origin

Summary: Wrong drop location from model explorer to diagram with negative origin

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	5.0.0
Hardware:	PC All

Importance:	P3 normal (vote)
Target Milestone:	6.1.2
Assignee:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:	543148
	Show dependency tree

Reported:	2017-09-06 10:28 EDT by Florian Barbin
Modified:	2019-02-15 09:01 EST (History)
CC List:	2 users (show)

See Also:	520629 Gerrit Change Git Commit Gerrit Change Gerrit Change Git Commit

Attachments
Use case to reproduce this issue (3.85 KB, application/zip) 2017-09-06 10:28 EDT, Florian Barbin	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Barbin

2017-09-06 10:28:42 EDT

Created attachment 270098 [details]
Use case to reproduce this issue

* Open new TC1041 representation 2 Blank representation.
* Make sure you have a vertical scrollbar. Move it in the middle for instance.
* Drag and Drop P2 on the diagram.
* P2 is not located at the place we dropped it. => KO
* If the "Snap To Grid" is activated, P2 is not snapped on the grid. => KO

Comment 1 Florian Barbin

2017-09-06 10:29:31 EDT

This issue has been detected during bug 520629

Comment 2 Eclipse Genie

2017-09-06 10:55:13 EDT

New Gerrit change created: https://git.eclipse.org/r/104471

Comment 3 Florian Barbin

2017-09-06 10:56:53 EDT

TODO: revert the gerrit once this bug is fixed.

Comment 4 Eclipse Genie

2017-09-06 12:35:31 EDT

Gerrit change https://git.eclipse.org/r/104471 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=63c28596f3822f08444a1c2019edf7f338481f89

Comment 5 Laurent Redor

2017-09-11 02:32:23 EDT

Idea of where is the problem with this gerrit: https://git.eclipse.org/r/#/c/104180/

Comment 6 Pierre-Charles David

2017-09-11 04:53:18 EDT

Reproduced with the attached project and steps.

Comment 7 Florian Barbin

2017-09-27 09:38:17 EDT

The drop location is not properly handle if at least one figure in the diagram has negative coordinates.

Comment 8 Eclipse Genie

2018-12-17 11:29:29 EST

New Gerrit change created: https://git.eclipse.org/r/134141

Comment 9 Eclipse Genie

2019-01-03 09:57:19 EST

Gerrit change https://git.eclipse.org/r/134141 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7b9b602e5ca30f9b21ba6dec4f1c17fb589259be

Comment 10 Pierre Guilet

2019-01-28 11:43:16 EST

Validated with OD CE 11.1.2

Comment 11 Pierre-Charles David

2019-02-15 09:01:33 EST

Available in Sirius 6.1.2, see https://wiki.eclipse.org/Sirius/6.1.2 for details.