521854 – [JUnit 5] Provide UI to add tags to be included or excluded in test run

Bug 521854 - [JUnit 5] Provide UI to add tags to be included or excluded in test run

Summary: [JUnit 5] Provide UI to add tags to be included or excluded in test run

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.8
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.7.1a
Assignee:	Sarika Sinha
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	488566 521246 525275 525547 525767
	Show dependency tree

Reported:	2017-09-05 04:12 EDT by Noopur Gupta
Modified:	2017-10-09 10:07 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Noopur Gupta

2017-09-05 04:12:00 EDT

See bug 521246.

This bug is to provide a separate UI in the "Test" tab of JUnit launch configuration where the user can enter tags to be included or excluded in the test run.

This should be enabled only when the "Test Runner" is set to JUnit 5.

Comment 1 Eclipse Genie

2017-09-05 06:09:49 EDT

New Gerrit change created: https://git.eclipse.org/r/104338

Comment 2 Noopur Gupta

2017-09-05 06:20:42 EDT

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/104338

Initial WIP patch on master branch which just adds new fields and resolves dependency issues.

Comment 3 Noopur Gupta

2017-09-05 06:38:19 EDT

Sarika, please take it forward.

Comment 4 Noopur Gupta

2017-09-05 06:47:28 EDT

See bug 483566 comment #15 also for working with multi-line text field.

We can have two such checkbox-enabled controls side-by-side above "Test runner" for "Include tags" and "Exclude Tags" where user can add newline separated tags which can be commented using a # (Similar to Prefs > Java > Appearance > Abbreviate package names).

Comment 5 Noopur Gupta

2017-09-06 10:18:23 EDT

See bug 521246 comment #3 for using the tags currently via "Program arguments" in the "Arguments" tab of JUnit launch configuration.

Comment 6 Sarika Sinha

2017-09-08 09:17:33 EDT

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/104338

Have updated the gerrit patch.

Add Tgas Button will open the dialog to specify include/exclude tags.
Ok on the dialog will save the tags and flags to launch configuration attributes.

1 known issue -
Exclude tag text field height is smaller than expected. I will be working on it.

Comment 7 Eclipse Genie

2017-09-27 06:42:02 EDT

Gerrit change https://git.eclipse.org/r/104338 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=224b6f9c90d942f3053db02920117ff0427dfff3

Comment 8 Eclipse Genie

2017-09-27 07:20:47 EDT

New Gerrit change created: https://git.eclipse.org/r/105851

Comment 9 Eclipse Genie

2017-09-27 07:21:29 EDT

Gerrit change https://git.eclipse.org/r/105851 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=fab07c25f3a77e19a722f09bad78c8939675c4a8

Comment 10 Noopur Gupta

2017-09-27 07:24:29 EDT

(In reply to Eclipse Genie from comment #9)
> Gerrit change https://git.eclipse.org/r/105851 was merged to [master].
> Commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=fab07c25f3a77e19a722f09bad78c8939675c4a8
> 

Fixed the issue to keep tags configuration button enabled for only JUnit 5, updated labels and made some polish changes.

TODO:
- Handle serializer/parser.
- Integrate the UI with launch configuration and runner.

Comment 11 Noopur Gupta

2017-09-27 08:55:34 EDT

(In reply to Noopur Gupta from comment #10)
> TODO:
> - Integrate the UI with launch configuration and runner.

Done. 

Also, enabled the UI and disabled help button in new dialog:
http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=cf0c3d9cb7db0caec91556a877a61dac60ec41c1

Comment 12 Eclipse Genie

2017-09-27 09:38:39 EDT

New Gerrit change created: https://git.eclipse.org/r/105859

Comment 13 Eclipse Genie

2017-09-27 11:25:02 EDT

Gerrit change https://git.eclipse.org/r/105859 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=da3037c7bdb384b10d82a935d74146e7d81fd1bf

Comment 14 Noopur Gupta

2017-09-27 11:33:15 EDT

All the changes have been released to master and R4_7 branches.

Comment 15 Noopur Gupta

2017-09-27 15:25:15 EDT

TODO: update N&N documentation - bug 525275.

Comment 16 Eclipse Genie

2017-09-27 15:41:31 EDT

New Gerrit change created: https://git.eclipse.org/r/105878

Comment 17 Eclipse Genie

2017-09-27 15:42:23 EDT

New Gerrit change created: https://git.eclipse.org/r/105879

Comment 18 Eclipse Genie

2017-09-27 15:42:45 EDT

Gerrit change https://git.eclipse.org/r/105878 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=4ebc60e3903ebb6cfa38fb6d220630b985e02153

Comment 19 Eclipse Genie

2017-09-27 15:43:06 EDT

Gerrit change https://git.eclipse.org/r/105879 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=7a034c23160c2a5eb5a5b6cb393607be059401ee

Comment 20 Sarika Sinha

2017-09-28 04:20:08 EDT

Eclipse SDK
Version: Oxygen.1a (4.7.1a)
Build id: M20170927-1700
OS: Windows 7, v.6.1, x86_64 / win32