Bug 521596 - IP Check invalid when editing on GitHub
Summary: IP Check invalid when editing on GitHub
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: GitHub (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 540694
Blocks:
  Show dependency tree
 
Reported: 2017-08-30 07:58 EDT by John Ament CLA
Modified: 2019-03-18 09:35 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Ament CLA 2017-08-30 07:58:05 EDT 
https://github.com/eclipse/microprofile-bom/pull/30 is an example pull request, directly edited on GitHub.

In https://bugs.eclipse.org/bugs/show_bug.cgi?id=521001 I had requested clarification on if sign offs were required.  I was told no, if the committer was an Eclipse Committer for the project.  I am a committer for MicroProfile but this commit is being flagged as not valid.  Shouldn't it be using my GitHub ID instead of email address?
Comment 1 John Ament CLA 2017-09-06 11:33:03 EDT 
Any update on this?
Comment 2 Eclipse Genie CLA 2017-09-06 15:07:00 EDT 
GitHub Pull Request 27 created by [MWEclipse]
https://github.com/eclipse/eclipse-webhook/pull/27
Comment 3 Eclipse Webmaster CLA 2017-09-06 15:12:37 EDT 
I've talked to Wayne and we do want to be checking the author rather than the committer.  The pull request I submitted should do that, so once it's been reviewed and accepted we should be in business.

In the mean time you can in fact merge requests like the example you gave.

-M.
Comment 4 John Ament CLA 2017-09-06 15:27:43 EDT 
That's awesome, thanks.  Can you ping me when its working?  Several of us on MP prefer using direct github editing, especially when it comes to spec changes.
Comment 5 Wayne Beaton CLA 2017-09-07 10:45:22 EDT 
(In reply to John Ament from comment #4)
> That's awesome, thanks.  Can you ping me when its working?  Several of us on
> MP prefer using direct github editing, especially when it comes to spec
> changes.

FWIW, this bug will be closed when it's working. Automatic ping.
Comment 6 Eclipse Genie CLA 2017-10-24 12:47:23 EDT 
GitHub Pull Request 27 created by [MWEclipse]
https://github.com/eclipse/eclipse-webhook/pull/27
Comment 7 Christopher Guindon CLA 2019-02-25 10:06:07 EST 
I believe this won't be an issue with the new version of the ECA Validation service which we are working on with Bug 540694 - Github IP validation needs to be more robust.
Comment 8 Christopher Guindon CLA 2019-03-18 09:35:50 EDT 
(In reply to Christopher Guindon from comment #7)
> I believe this won't be an issue with the new version of the ECA Validation
> service which we are working on with Bug 540694 - Github IP validation needs
> to be more robust.

Closing this bug.