Bug 521455 - DiffFormatter must apply filters and EOL conversions
Summary: DiffFormatter must apply filters and EOL conversions
Status: NEW
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 normal with 3 votes (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 342372
  Show dependency tree
 
Reported: 2017-08-28 04:36 EDT by Thomas Wolf CLA
Modified: 2018-12-04 09:15 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2017-08-28 04:36:12 EDT 
DiffFormatter uses the raw blob contents to produce the diff. This is wrong; it must apply smudge filters as defined by .gitattributes, and also EOL conversion as defined by core.autocrlf, core.eol, or core.crlf.

See also bug 390818, bug 361503, and bug 497439.