Bug 521068 - It should be possible to inherit from SessionFactoryImpl
Summary: It should be possible to inherit from SessionFactoryImpl
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 5.0.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 5.1.0   Edit
Assignee: Maxime Porhel CLA
QA Contact: Julien Dupont CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-08-17 10:42 EDT by Maxime Porhel CLA
Modified: 2017-11-08 03:36 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2017-08-17 10:42:41 EDT
SessionFactoryImpl is the default implementation of the SessionFactory interface. It is also responsible to init the SessionFactory.INSTANCE singleton. 

SessionFactoryImpl is currently a final class and session factory providers default way to provide their own factory is to copy the class and adapt it, then they miss the evolutions of the default factory, which might be acceptable for an internal class. 

I propose as a first step to update the factory and to remove the final modifier in order to allow other projects like Capella to begin to inherit form it instead of copying it. 
We might in later version move it from internal to api packages.
Comment 1 Maxime Porhel CLA 2017-08-18 05:31:13 EDT
See also https://git.polarsys.org/r/#/c/4903/ on Capella side which validates this enhancement.
Comment 3 Pierre-Charles David CLA 2017-08-22 04:02:14 EDT
Closing, as I believe we're done with f0c22e45a393a6a9cc90a8202bcbdfb1c2057a3a. @maxime, feel free to reopen if there are more things to do (and mention which ones).
Comment 4 Eclipse Genie CLA 2017-09-06 04:54:51 EDT
New Gerrit change created: https://git.eclipse.org/r/104422
Comment 6 Pierre-Charles David CLA 2017-11-08 03:36:51 EST
Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.