Bug 52100 - C++ classes should be viewable "flat" or "treeed"
Summary: C++ classes should be viewable "flat" or "treeed"
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 enhancement with 1 vote (vote)
Target Milestone: 4.0   Edit
Assignee: Doug Schaefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 150470 (view as bug list)
Depends on:
Blocks: 191353
  Show dependency tree
 
Reported: 2004-02-15 12:34 EST by Thomas Fletcher CLA
Modified: 2008-06-20 10:04 EDT (History)
3 users (show)

See Also:


Attachments
Proposed fix (3.30 KB, patch)
2007-06-02 21:32 EDT, Sergey Prigogin CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Fletcher CLA 2004-02-15 12:34:49 EST
Currently C++ classes are presented using the private, public, protected
tree type of indirection.  This often obscures the data requiring that you
dig down one extra level in order to find what you are after (if you are
not aware of its "protection".

There should be a label decoration for these three attributes and the 
image used to decorate the class members appropriately.  (or put the
information in the details pane)

Then the tree could be collapsed without loosing any of this information
but opening up the possiblity for easier data exploration.
Comment 1 Kleo Hapitas CLA 2004-07-07 16:54:28 EDT
PR was not targeted to any particular release. Changing target milestone to 2.1
Comment 2 Nobody - feel free to take it CLA 2004-11-15 18:47:42 EST
Moving the target milestone to 3.0.
Comment 3 Nobody - feel free to take it CLA 2005-06-10 11:40:00 EDT
Deferred.
Comment 4 Nobody - feel free to take it CLA 2005-09-09 15:10:50 EDT
Reassigning to the pool.
Comment 5 Nobody - feel free to take it CLA 2006-08-30 04:26:39 EDT
*** Bug 150470 has been marked as a duplicate of this bug. ***
Comment 6 Sergey Prigogin CLA 2007-06-02 21:32:26 EDT
Created attachment 69876 [details]
Proposed fix

This simple change removes access qualifier nodes from the variable tree and replaces them with their children. Mikhail, please review and apply.
Comment 7 Nobody - feel free to take it CLA 2007-06-04 05:39:59 EDT
Sergey, the patch simply removes the access qualifier nodes. The request is to add a preference that allows users to choose the presentation of C++ classes.
Comment 8 Doug Schaefer CLA 2007-06-04 09:52:29 EDT
(In reply to comment #7)
> Sergey, the patch simply removes the access qualifier nodes. The request is to
> add a preference that allows users to choose the presentation of C++ classes.

I for one wouldn't miss the access qualifier nodes...
Comment 9 Nobody - feel free to take it CLA 2007-06-04 09:59:25 EDT
(In reply to comment #8)
I don't really care about it either, but removing it means the documentation change for all gdb based implementations. It seems like IBM has been running automatic UI tests recently, they may be affected too.
Comment 10 Doug Schaefer CLA 2007-06-04 10:33:27 EDT
(In reply to comment #9)
> (In reply to comment #8)
> I don't really care about it either, but removing it means the documentation
> change for all gdb based implementations. It seems like IBM has been running
> automatic UI tests recently, they may be affected too.

Not sure that should be the criteria driving the feature going forward. I don't remember seeing the access protection nodes when I used gdb from the command line. That probably means I didn't care about them and went straight to the data. I think this is one aspect that really sticks out as a negative in the CDT debug experience, and always has. Saying that I guess we should have raised a bug about when I first ran into it years ago.
Comment 11 Sergey Prigogin CLA 2007-06-04 12:58:20 EDT
Although the bug called for label decorations related to access type, I feel strongly that access type has no value for debugging. Distinguishing instance and static variables would be nice, but this is a completely separate issue.

This bug is more than three years old. We shouldn't allow it to see another birthday.
Comment 12 Sergey Prigogin CLA 2007-06-05 13:27:23 EDT
RC3 is approaching quickly. Please apply the patch before it's too late.
Comment 13 Doug Schaefer CLA 2007-06-05 14:22:18 EDT
O.K. If I don't hear anything else by tomorrow. I'll take this.
Comment 14 Doug Schaefer CLA 2007-06-06 12:53:18 EDT
Taking it.
Comment 15 Doug Schaefer CLA 2007-06-06 16:18:26 EDT
I have applied the patch. Thanks, Sergey!

We still don't have label decorations for the variables to show thier protection so I've cloned this bug as 191353 to take care of that.
Comment 16 Sergey Prigogin CLA 2007-06-06 20:33:19 EDT
Thanks a lot, Doug.