Bug 520756 - Extract IElementDeltaBuilder from ElementDelta.Builder
Summary: Extract IElementDeltaBuilder from ElementDelta.Builder
Status: RESOLVED FIXED
Alias: None
Product: Handly
Classification: Technology
Component: Core (show other bugs)
Version: 0.8   Edit
Hardware: All All
: P3 enhancement
Target Milestone: 0.8   Edit
Assignee: Vladimir Piskarev CLA
QA Contact:
URL:
Whiteboard: breakingchange
Keywords: api
Depends on:
Blocks:
 
Reported: 2017-08-09 09:38 EDT by Vladimir Piskarev CLA
Modified: 2017-08-09 09:49 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Piskarev CLA 2017-08-09 09:38:22 EDT 
Currently, some classes in Handly such as Body and ElementChangeRecorder (formerly known as ElementDifferencer) have a dependency on the class ElementDelta.Builder right in their API, which in turn couples them with the default implementation class for an element delta, ElementDelta. We'll extract an interface, IElementDeltaBuilder, from the class ElementDelta.Builder, and use the new interface in place of the class to reduce coupling where appropriate.
Comment 1 Vladimir Piskarev CLA 2017-08-09 09:49:34 EDT 
Pushed to master:
http://git.eclipse.org/c/handly/org.eclipse.handly.git/commit/?id=b0e7bc77acf13165252a9cee67090ee33bef6319

Breaking changes:

* Body#findContentChange(Body, IElement, ElementDelta.Builder) has been replaced with #findContentChange(Body, IElement, IElementDeltaBuilder). (Same for SourceElementBody.)