Bug 520735 - Repositories Tab: "Link with selection" adds submodules as root nodes
Summary: Repositories Tab: "Link with selection" adds submodules as root nodes
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 4.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 5.5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2017-08-09 05:12 EDT by Marvin Hohlfeld CLA
Modified: 2019-07-03 08:47 EDT (History)
2 users (show)

See Also:

Attachments
Submodule gets added as root node (81.14 KB, image/png)
2017-08-09 05:12 EDT, Marvin Hohlfeld CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marvin Hohlfeld CLA 2017-08-09 05:12:38 EDT 
Created attachment 269754 [details]
Submodule gets added as root node

Tested with 4.9.0.201708071146

When "Link with selection" is activated for the Git Repositories tab and a file from a submodule working tree gets selected, the submodule gets added as a root node to the repository list where the file will be highlighted (instead of just highlighting the file in the submodule leaf).

This is annoying as submodules gets present multiple times in the list and the clarity gets lost.
Comment 1 Thomas Wolf CLA 2017-08-09 11:37:57 EDT 
Oops. Culprit is RepositoriesView.checkNotConfiguredRepositories(), called from showPaths(). At least that means it's *not* caused by https://git.eclipse.org/r/#/c/100045/ .
Comment 2 Marvin Hohlfeld CLA 2017-11-15 08:22:35 EST 
Hi Thomas, do you have any news on this? It's still very annoying when dealing with submodules...
Comment 3 Thomas Wolf CLA 2017-11-15 10:14:30 EST 
No. Didn't have any time to look at this.

Patches on Gerrit are welcome, though!
Comment 4 Eclipse Genie CLA 2019-07-02 02:33:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/145263
Comment 5 Eclipse Genie CLA 2019-07-03 08:47:07 EDT 
Gerrit change https://git.eclipse.org/r/145263 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=cd2aeaa7c9ebaa04e535eb9e177b5d8b979e0dc0