Bug 520648 - [9] module-info should be displayed with correct icons
Summary: [9] module-info should be displayed with correct icons
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: BETA J9   Edit
Assignee: Noopur Gupta CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 520651
Blocks:
  Show dependency tree
 
Reported: 2017-08-08 01:58 EDT by Noopur Gupta CLA
Modified: 2017-08-08 02:58 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2017-08-08 01:58:58 EDT 
From bug 501507 comment #6:

(In reply to Stephan Herrmann)
> BTW, I found that module-info inside a classfile is displayed with the
> package-visible-class icon, not the module icon - both in package explorer
> and outline. Did I break this, or was it broken before? Also the classfile
> icon has the package-visibility decoration.

These are existing issues which are not yet handled.
Comment 1 Noopur Gupta CLA 2017-08-08 02:58:56 EDT 
> > BTW, I found that module-info inside a classfile is displayed with the
> > package-visible-class icon, not the module icon - both in package explorer
> > and outline. 

This is due to bug 520651. Handled it in JavaElementImageProvider for now.

> > Also the classfile icon has the package-visibility decoration.

Fixed.

Released the fix with:
http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?h=BETA_JAVA9&id=b4af8d81af90c33f4bd100918f07d67cf6476708