520633 – Snap to grid constraint is not taken into account after "Arrange All" action.

Bug 520633 - Snap to grid constraint is not taken into account after "Arrange All" action.

Summary: Snap to grid constraint is not taken into account after "Arrange All" action.

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	5.0.0
Hardware:	PC All

Importance:	P3 normal (vote)
Target Milestone:	5.1.0
Assignee:	Florian Barbin
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:

Reported:	2017-08-07 11:38 EDT by Jessy Mallet
Modified:	2017-11-08 03:37 EST (History)
CC List:	3 users (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit 521449 521976

Attachments
Test case to use. (6.72 KB, application/x-zip-compressed) 2017-08-07 11:38 EDT, Jessy Mallet	no flags	Details
ScreenShot of the "Arrange all" behaviour (81.89 KB, image/png) 2017-08-07 11:39 EDT, Jessy Mallet	no flags	Details
Properties of the grid (15.27 KB, image/png) 2017-08-08 04:07 EDT, Jessy Mallet	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jessy Mallet

2017-08-07 11:38:58 EDT

Created attachment 269718 [details]
Test case to use.

On diagram with "Snap to grid" activated, when user wants to launch "Arrange All" action, border Node in container (which were aligned on the grid before) are not aligned on the grid anymore in spite of container is aligned on the grid.

"Arrange All" action should take into account "Snap to grid" constraints.


Step to reproduce :
* import in your workspace the modeling project ArrangeAll.zip,
* open representation "new packageDiag",
* make sure that "Snap to Grid" box is marked in properties view of diagram (tab Rulers&Grid) 
* clic on "Arrange All" action (icon on the top left of the diagram)
* create an other class at the same localisation than before
* border Nodes are arranged but they are not snap on grid anymore -> KO
  They should be align on the grid.

Comment 1 Jessy Mallet

2017-08-07 11:39:34 EDT

Created attachment 269719 [details]
ScreenShot of the "Arrange all" behaviour

Comment 2 Jessy Mallet

2017-08-08 04:07:39 EDT

Created attachment 269730 [details]
Properties of the grid

Comment 3 Florian Barbin

2017-08-08 04:45:40 EDT

To reproduce the result of the screenshot, don't forget to unpin C2 and C3.

Comment 4 Eclipse Genie

2017-08-18 12:11:14 EDT

New Gerrit change created: https://git.eclipse.org/r/103316

Comment 5 Eclipse Genie

2017-08-18 12:11:17 EDT

New Gerrit change created: https://git.eclipse.org/r/103317

Comment 6 Eclipse Genie

2017-09-01 10:16:02 EDT

Gerrit change https://git.eclipse.org/r/103316 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=46eb63c166ec2c8b85b6d0a91d27c479d08aba94

Comment 7 Eclipse Genie

2017-09-01 10:16:03 EDT

Gerrit change https://git.eclipse.org/r/102948 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=eb2d56553e8bba471acd4f3724d7fa11e5915708

Comment 8 Eclipse Genie

2017-09-01 10:16:05 EDT

Gerrit change https://git.eclipse.org/r/103317 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=534f71bb6e90acd18b7703bf7b3654f80b8ad4d3

Comment 9 Florian Barbin

2017-09-05 03:36:42 EDT

In some cases, the border node snap location is in conflict with the parent label. In that case the border node might not be snapped. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=521449

Comment 10 Pierre-Charles David

2017-11-08 03:37:16 EST

Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.