Bug 520581 - Exceptions when dropping non-model files into the aird editor
Summary: Exceptions when dropping non-model files into the aird editor
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 5.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 5.1.0   Edit
Assignee: Pierre-Charles David CLA
QA Contact:
URL:
Whiteboard: need_test
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-08-04 11:54 EDT by Jessy Mallet CLA
Modified: 2017-11-08 03:37 EST (History)
3 users (show)

See Also:

Attachments
Test case to use. (2.26 KB, application/x-zip-compressed)
2017-08-04 11:54 EDT, Jessy Mallet CLA 		no flags Details
Trace of exception (11.15 KB, text/plain)
2017-08-04 11:55 EDT, Jessy Mallet CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessy Mallet CLA 2017-08-04 11:54:02 EDT 
Created attachment 269693 [details]
Test case to use.

In air editor, on the models block, when user add a txt file (or other file which is not a model) with button "Add..." , nothing happened on the editor.
Worst, an error appears in the errorLog view (see stackTrace joined).

It would be pleasant if add action opens an error message window to explained the problem instead of error in errorLog view.


Step to reproduce :
* import in your workspace the modeling project AddFileInEditor.zip,
* open aird file with the aird editor,
* on the models block of the aird editor, add the file myTest.txt with the "Add..." button,
* nothing happened on aird editor and error occurs in errorLog -> KO
Comment 1 Jessy Mallet CLA 2017-08-04 11:55:17 EDT 
Created attachment 269694 [details]
Trace of exception
Comment 2 Florian Barbin CLA 2017-08-09 03:41:05 EDT 
Issue accepted and marked as triaged.
Comment 3 Pierre-Charles David CLA 2017-08-22 08:43:18 EDT 
Caused by https://bugs.eclipse.org/bugs/show_bug.cgi?id=517532 not properly filtering its input. It should probably have been reopened instead of a new ticket created, but too late now.
Comment 4 Eclipse Genie CLA 2017-08-22 09:42:38 EDT 
New Gerrit change created: https://git.eclipse.org/r/103459
Comment 6 Pierre-Charles David CLA 2017-08-28 09:37:22 EDT 
Fixed by 8e96cc411a8e3a2d5bf2bf36a064fb3eb5444fba, but still needs a non-regression test.
Comment 7 Pierre-Charles David CLA 2017-09-21 11:58:39 EDT 
Closing with the need_test keyword: for the "parent" ticket https://bugs.eclipse.org/bugs/show_bug.cgi?id=517532 we were not able to create a test that works reliably on all systems.
Comment 8 Jessy Mallet CLA 2017-09-26 05:30:19 EDT 
Validated on Sirius Stable 5.1.0.201709221508
Comment 9 Pierre-Charles David CLA 2017-11-08 03:37:02 EST 
Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.