520572 – CustomWidgetDescriptionConverter does not translate name to identifier

Bug 520572 - CustomWidgetDescriptionConverter does not translate name to identifier

Summary: CustomWidgetDescriptionConverter does not translate name to identifier

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Properties (show other bugs)
Version:	5.0.0
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	5.0.2
Assignee:	Pierre-Charles David
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:	519552
Blocks:
	Show dependency tree

Reported:	2017-08-04 09:15 EDT by Pierre-Charles David
Modified:	2017-09-11 10:07 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pierre-Charles David

2017-08-04 09:15:10 EDT

+++ This bug was initially created as a clone of Bug #519552 +++

The converter for custom property widget descriptions (org.eclipse.sirius.properties.core.internal.converter.CustomWidgetDescriptionConverter) uses a generic method to copy all attributes to the EEF model. This leaves the 'identifier' attribute null since it does no longer exist in the Sirius model (now named 'name'). Child elements (e.g. custom expressions) are also affected.
The TextDescriptionConverter does it correctly: 
eefTextDescription.setIdentifier(textDescription.getName());

Observed in version 5.0.1

Comment 1 Pierre-Charles David

2017-08-04 09:15:34 EDT

Clone to backport the fix on maintenance version 5.0.2.

Comment 2 Eclipse Genie

2017-08-07 08:36:37 EDT

New Gerrit change created: https://git.eclipse.org/r/102601

Comment 3 Eclipse Genie

2017-08-16 05:09:09 EDT

Gerrit change https://git.eclipse.org/r/102601 was merged to [v5.0.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b1c1fbf639eec60e6fef58d482e0b7b48d33f8c0

Comment 4 Pierre-Charles David

2017-08-16 05:10:28 EDT

Fixed by b1c1fbf639eec60e6fef58d482e0b7b48d33f8c0.

Comment 5 Pierre-Charles David

2017-09-11 04:21:17 EDT

I'm marking as verified on 5.0.2rc2. I had to verify the behavior in debug, as the original report does not indicate how the bug translates in user-visible terms, and the EEF model instances (resulting from the conversion) are not serialized or easily accessible otherwise.

Comment 6 Pierre-Charles David

2017-09-11 10:07:50 EDT

Available in Sirius 5.0.2.