519989 – Remove empty dispose and inputChanged methods in PDE

Bug 519989 - Remove empty dispose and inputChanged methods in PDE

Summary: Remove empty dispose and inputChanged methods in PDE

Status:	VERIFIED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.7
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.8 M7
Assignee:	Moritz Aleithe
QA Contact:

URL:
Whiteboard:
Keywords:	bugday, helpwanted

Depends on:
Blocks:

Reported:	2017-07-21 04:45 EDT by Lars Vogel
Modified:	2018-05-10 09:33 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2017-07-21 04:45:12 EDT

IStructuredContentProvider provides via IContentProvider empty default methods for dispose and inputChanged. I suggest we remove the empty implementations from PDE code.

Comment 1 Vikas Chandra

2018-03-13 04:57:05 EDT

Moving out of 4.8.

If planning for 4.8, it can be triaged back to 4.8M7 with a patch.

Comment 2 Eclipse Genie

2018-03-21 16:08:54 EDT

New Gerrit change created: https://git.eclipse.org/r/119911

Comment 3 Eclipse Genie

2018-03-21 16:13:29 EDT

New Gerrit change created: https://git.eclipse.org/r/119913

Comment 4 Eclipse Genie

2018-03-21 16:24:35 EDT

New Gerrit change created: https://git.eclipse.org/r/119916

Comment 5 Eclipse Genie

2018-03-21 16:27:49 EDT

New Gerrit change created: https://git.eclipse.org/r/119917

Comment 6 Eclipse Genie

2018-03-21 16:35:04 EDT

New Gerrit change created: https://git.eclipse.org/r/119919

Comment 7 Eclipse Genie

2018-03-21 16:35:05 EDT

New Gerrit change created: https://git.eclipse.org/r/119918

Comment 8 Eclipse Genie

2018-03-21 16:35:07 EDT

New Gerrit change created: https://git.eclipse.org/r/119920

Comment 9 Moritz Aleithe

2018-03-21 16:39:27 EDT

I've split up the changes per-project, I hope that doesn't make merging too painful, just wanted to have it "nice and ordered"

Comment 10 Lars Vogel

2018-03-21 16:40:03 EDT

(In reply to Moritz Aleithe from comment #9)
> I've split up the changes per-project, I hope that doesn't make merging too
> painful, just wanted to have it "nice and ordered"

Great thanks, this also make reviewing them much easier.

Comment 11 Eclipse Genie

2018-03-21 16:48:25 EDT

Gerrit change https://git.eclipse.org/r/119911 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=74d3c5e4ac3fa97f7391b7d7b4051d9ce3377d1c

Comment 12 Eclipse Genie

2018-03-21 16:48:26 EDT

Gerrit change https://git.eclipse.org/r/119913 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=916fa56867f914a1d0053ed71ee5213f41943c9a

Comment 13 Eclipse Genie

2018-03-21 16:48:28 EDT

Gerrit change https://git.eclipse.org/r/119916 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a8d00048defa7a3a45ba2828b4ab184617595ccd

Comment 14 Eclipse Genie

2018-03-21 16:48:30 EDT

Gerrit change https://git.eclipse.org/r/119917 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=48b14500d4ac75babac916a9ee21c7cc2d0e3683

Comment 15 Eclipse Genie

2018-03-21 16:48:43 EDT

Gerrit change https://git.eclipse.org/r/119918 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=8d1f301c5dd058c5897d84ad37772e5df24c4ae5

Comment 16 Eclipse Genie

2018-03-21 16:48:45 EDT

Gerrit change https://git.eclipse.org/r/119919 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=4f813afdd5418cb5d9eef0a9c51580bf9a4311ad

Comment 17 Moritz Aleithe

2018-03-21 17:01:31 EDT

I would close this after the last git Commit? Not yet 100% sure of the process at eclipse ;)

Comment 18 Eclipse Genie

2018-03-21 17:12:32 EDT

Gerrit change https://git.eclipse.org/r/119920 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=41bbe18f7a12f0a4983ceeca021bebd564019b85

Comment 19 Lars Vogel

2018-03-21 17:13:25 EDT

(In reply to Moritz Aleithe from comment #17)
> I would close this after the last git Commit? Not yet 100% sure of the
> process at eclipse ;)

Thanks Moritz. If there is nothing more pending we can close the bug. Thanks for your contribution.

Comment 20 Vikas Chandra

2018-05-10 09:33:05 EDT

verified by code inspection