Community
Participate
Working Groups
Copied from bug 516551 comment 13 : (In reply to Till Brychcy from comment #13) >[...] > Everything that is bold is more difficult to read in this font in the dark > design. > > Maybe this should be reconsidered - or maybe you should update the dark > design so it works better with this font? > Also see attached screen shots on bug 516551.
This is a JDT issue. Can someone pls. assign it to JDT UI?
New Gerrit change created: https://git.eclipse.org/r/101644
Created attachment 269461 [details] Java Syntax Coloring with my fix
With my fix the bold font face is used in the dark theme at the same places as it is used in the light theme.
I contributed the original dark styling to JDT. Change is fine for me, if Till agrees to it.
New Gerrit change created: https://git.eclipse.org/r/101860
Created attachment 269512 [details] Java Syntax Coloring with Till's proposed changes
(In reply to Matthias Becker from comment #4) > With my fix the bold font face is used in the dark theme at the same places > as it is used in the light theme. (In reply to Lars Vogel from comment #5) > I contributed the original dark styling to JDT. Change is fine for me, if > Till agrees to it. It is already more readable, but I have some improvement suggestions: 1) I think bold shouldn't be used for the keywords either. Bold looks good in the light theme, but it leads to blurryness with the black background. 2) Some colors are too close the keyword-color, and the keyword-color doesn't really match the style of the other colors. I suggest the following changes: - Slightly increase the saturation of the keywords color - Use grey for annotations. They are anyway detectable as annotations because of their '@'-prefix. - Use yellow (light for usage, saturated for declaration) for local variables. - Use purple for the type arguments See screenshot and the patch in https://git.eclipse.org/r/#/c/101860/ (I have created a fresh patch because I'm not a jdt.ui commiter, so I could not push an update to the existing patch. If this is ok for you, please update accordingly your patch instead) WDYT?
(In reply to Till Brychcy from comment #8) > 1) I think bold shouldn't be used for the keywords either. Bold looks good > in the light theme, but it leads to blurryness with the black background. I don't see this blurriness. But it's ok for me. > 2) Some colors are too close the keyword-color, and the keyword-color > doesn't really match the style of the other colors. I suggest the following > changes: > - Slightly increase the saturation of the keywords color I like this. > - Use grey for annotations. They are anyway detectable as annotations > because of their '@'-prefix. Good idea. > - Use yellow (light for usage, saturated for declaration) for local > variables. Yes, the old color was to close to the "keyword" color. > - Use purple for the type arguments ok > (I have created a fresh patch because I'm not a jdt.ui commiter, so I could > not push an update to the existing patch. If this is ok for you, please > update accordingly your patch instead) I am not a JDT committer either. But I will update my change accordingly. > WDYT? I like your changes.
(In reply to Till Brychcy from comment #8) > (I have created a fresh patch because I'm not a jdt.ui commiter, so I could > not push an update to the existing patch. If this is ok for you, please > update accordingly your patch instead) I just uploaded patchset 2 that includes Till's changes.
(In reply to Matthias Becker from comment #10) > (In reply to Till Brychcy from comment #8) > > (I have created a fresh patch because I'm not a jdt.ui commiter, so I could > > not push an update to the existing patch. If this is ok for you, please > > update accordingly your patch instead) > > I just uploaded patchset 2 that includes Till's changes. @Lars, are these changes ok for you?
@Till, I asked David in the Gerrit to do a review. He is a 100% dark theme user under Linux.
(In reply to Lars Vogel from comment #12) > @Till, I asked David in the Gerrit to do a review. He is a 100% dark theme > user under Linux. David left some comment in Gerrit. Till, can you have a look at them and proceed with this issue?
https://bugs.eclipse.org/bugs/show_bug.cgi?id=519950 (Moving the discussion from gerrit to here) David Weiser wrote for Patch Set 2: >I like the usage of regular font style. I also like that the colors for e.g. >variable declaration are not that similar to the keyword color anymore. But I >think the yellow for local variable usage does not differ enough from white. Hmm they do look different from white to me and anyway the only other white things in methods are operators, braces and package names (which are very rare). But this may be a matter of the screen (and maybe the configured gamma), so let's try to improve it a bit. What do you think of 243,236,121 (RGB) = Hex F3EC79? Or do you have a suggestion? I think the design criteria should be: - Local variable usages should have a color that is obviously a variation of the color of the declarations (but be different enough, so you can quickly find the declarations) - The color should feel related to the other colors. (hard to describe)
The color you suggested looks a bit better on my screen. Also next to the green color of a method call. I would suggest to use this instead of the current one.
(In reply to Till Brychcy from comment #14) > What do you think of 243,236,121 (RGB) = Hex F3EC79? (In reply to David Weiser from comment #15) > The color you suggested looks a bit better on my screen. Also next to the > green color of a method call. I would suggest to use this instead of the > current one. @Matthias, can you please update the patch with that color? semanticHighlighting.localVariable.color=243,236,121
(In reply to Till Brychcy from comment #16) > @Matthias, can you please update the patch with that color? > > semanticHighlighting.localVariable.color=243,236,121 Done.
(In reply to Matthias Becker from comment #17) > (In reply to Till Brychcy from comment #16) > > @Matthias, can you please update the patch with that color? > > > > semanticHighlighting.localVariable.color=243,236,121 > Done. Thanks. @Noopur, do you know any other dark theme users whom we should ask for an opinion (esp. someone who uses Windows)? Or, if you don't think that is necessary, can you please commit it?
(In reply to Till Brychcy from comment #18) > @Noopur, do you know any other dark theme users whom we should ask for an > opinion (esp. someone who uses Windows)? Adding Manoj who uses dark theme on Windows. Manoj, please provide your feedback.
Gerrit change https://git.eclipse.org/r/101644 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=1c7bd1e2ff7a0bf364d2820bf603d1ce43e52e21
Thanks, everyone! I have released the change so that we can get the feedback from other users.
Please add to the N&N m2
(In reply to Lars Vogel from comment #22) > Please add to the N&N m2 @Till: Can you write the N&N entry as you did the most work on the colors?
New Gerrit change created: https://git.eclipse.org/r/104811
Gerrit change https://git.eclipse.org/r/104811 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=bcaa5ef64601206b5ecb1d81106de878f6f8f3d1
(In reply to Matthias Becker from comment #23) > (In reply to Lars Vogel from comment #22) > > Please add to the N&N m2 > > @Till: Can you write the N&N entry as you did the most work on the colors? Done. (In reply to Eclipse Genie from comment #24) > New Gerrit change created: https://git.eclipse.org/r/104811
