519926 – Allow custom debugger decide on filtering

Bug 519926 - Allow custom debugger decide on filtering

Summary: Allow custom debugger decide on filtering

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Debug (show other bugs)
Version:	3.8.2
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	4.8 M1
Assignee:	Andrey Loskutov
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-07-20 05:07 EDT by Andrey Loskutov
Modified:	2017-08-01 06:32 EDT (History)
CC List:	1 user (show)

See Also:	89643 344165 Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrey Loskutov

2017-07-20 05:07:31 EDT

Due bug 89643, JDIThread.StepHandler disallows non-java strati to be used with step filters. There is a bug 344165 requesting this behavior to be configurable via UI.

We have a debugger which understands java and other strati and which extends JDIThread so for our need it would be enough if the JDIThread.StepHandler would allow the JDIThread to decide if the step filters should be enabled or not.

This is easy to implement (just extract the if() condition added via bug 89643 into the protected method in JDIThread), and will not break anyone, because JDIThread is internal.

I'm going to provide a patch.

Comment 1 Eclipse Genie

2017-07-20 07:02:00 EDT

New Gerrit change created: https://git.eclipse.org/r/101633

Comment 2 Eclipse Genie

2017-07-20 07:35:46 EDT

Gerrit change https://git.eclipse.org/r/101633 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=8b34bf7aa5a604d1de04f0f8e422c932fb152588

Comment 3 Sarika Sinha

2017-08-01 06:32:56 EDT

Verified by code inspection using

Eclipse SDK
Version: Photon (4.8)
Build id: I20170731-2000
OS: Windows 7, v.6.1, x86_64 / win32