Bug 519831 - "Clean repository" does not report errors
Summary: "Clean repository" does not report errors
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 4.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-18 10:23 EDT by Michael Keppler CLA
Modified: 2017-08-30 09:17 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2017-07-18 10:23:28 EDT
The repository clean command silently ignores exceptions instead of showing an error dialog. Please show an error, since following git operations can be very confusing, if those "cleaned" files are suddenly again in the staging area.

Copy of a related entry in my error log:

org.eclipse.egit.ui
Error
Tue Jul 18 16:15:22 CEST 2017
Unexpected exception while cleaning

org.eclipse.jgit.api.errors.JGitInternalException: Could not delete file D:\development\esdl\git\project33\tests\com.etas.arxml2esdl.map.tests\target
	at org.eclipse.jgit.api.CleanCommand.call(CleanCommand.java:137)
	at org.eclipse.egit.ui.internal.clean.CleanRepositoryPage$9.run(CleanRepositoryPage.java:271)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:119)
Caused by: java.io.IOException: Could not delete file D:\development\esdl\git\project33\tests\com.etas.arxml2esdl.map.tests\target
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:198)
	at org.eclipse.jgit.api.CleanCommand.cleanPath(CleanCommand.java:184)
	at org.eclipse.jgit.api.CleanCommand.call(CleanCommand.java:134)
	... 2 more
Comment 1 Eclipse Genie CLA 2017-08-30 09:17:45 EDT
New Gerrit change created: https://git.eclipse.org/r/103990