Bug 51959 - Default formatter should be "Java Conventions"
Summary: Default formatter should be "Java Conventions"
Status: RESOLVED DUPLICATE of bug 65531
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-13 10:19 EST by Douglas Pollock CLA
Modified: 2004-06-04 11:05 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Pollock CLA 2004-02-13 10:19:18 EST 
The default formatter should be "Java Conventions" and not "Default" ("Basic"?).
 I feel that most people expect the default formatting style to at least
approximate Sun's Java Conventions.

The current default does a lot of things that are unexpected, such as aggressive
collapsing of white space.
Comment 1 Olivier Thomann CLA 2004-02-15 13:00:30 EST 
By default, we want to preserve a formatting close to the old formatter settings.
It is easy enough to switch to the Java conventions settings.
Comment 2 Ed Burnette CLA 2004-02-15 17:14:16 EST 
How an you have one that is close to the old formatter settings when everybody 
had their own that varied from the default?

I recommending having two profiles, Java standard and Eclipse standard. 
Eclipse standard would be whatever most people in the Eclipse platform group 
use. This will be helpful when comitting code to Eclipse. The default should 
be Eclipse standard.
Comment 3 Olivier Thomann CLA 2004-02-16 10:11:43 EST 
It is trivial to switch to the java conventions settings. I really don't see why
this is an issue. It is also easy to define a new set of settings based on one
of the two predefined settings.
I won't try to define an Eclipse standard settings. How do you want to define a
"standard" for all developers for something that is a matter of taste. This is
why we have a way to define new settings.
Comment 4 Olivier Thomann CLA 2004-04-08 09:38:01 EDT 
Close as WORKSFORME.
Comment 5 Olivier Thomann CLA 2004-04-08 09:38:22 EDT 
Reopen. Wrong bug.
Comment 6 Olivier Thomann CLA 2004-04-16 12:47:28 EDT 
Answer for comment 2, I am not aware of any Eclipse standard. The default
settings are closed to what was done in the old formatter.
JDT/UI is responsible for settings what profile is the default.
Move to JDT/UI.
I recommend not changing this. It is easy to move to Java conventions profile.
Comment 7 Ed Burnette CLA 2004-04-16 12:50:56 EDT 
DJ Houghton and Jeff McAffer seem to be trying to standardize on something 
judging by recent platform-core-dev traffic.
Comment 8 Dirk Baeumer CLA 2004-05-05 13:57:45 EDT 
Olivier, we are using the profile as a default that is marked by JDT/Core as 
default. To not have different defaults depending on whether the JDT/UI is 
loaded shouldn't JDT/Core define the default ?
Comment 9 Philipe Mulet CLA 2004-05-10 05:15:49 EDT 
RE: comment #7. DJ and Jeff are trying to define conventions used within their 
component. It isn't the Eclipse style, which doesn't exist.

Closing. No action planned.
Comment 10 Olivier Thomann CLA 2004-06-04 11:04:59 EDT 
Reopen considering bug 65531.
Comment 11 Olivier Thomann CLA 2004-06-04 11:05:22 EDT 
Close as duplicate of bug 65531

*** This bug has been marked as a duplicate of 65531 ***