Bug 519203 - Moving shape attached to multiple orthogonal connections is slow
Summary: Moving shape attached to multiple orthogonal connections is slow
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF MVC (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-05 04:52 EDT by Victor Johnsson CLA
Modified: 2018-07-02 04:58 EDT (History)
0 users

See Also:

Attachments
Faster visual updates in 4321 (393.96 KB, image/gif)
2017-07-05 04:52 EDT, Victor Johnsson CLA 		no flags Details
Slower visual updates in 4403 (181.81 KB, image/gif)
2017-07-05 04:53 EDT, Victor Johnsson CLA 		no flags Details
Java Mission Control report of dragging connections as shown in the gif (172.72 KB, application/octet-stream)
2018-07-02 04:58 EDT, Victor Johnsson CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Johnsson CLA 2017-07-05 04:52:42 EDT 
Created attachment 269204 [details]
Faster visual updates in 4321

Moving shape attached to multiple orthogonal connections is slow. The performance for this has decreased between milestone release 4321 (5.0.0.201705150808) and integration release 4403 (5.0.0.201706131249). This happens in the GEF logo example when run as an Eclipse plugin.

How to reproduce:
1. Connect 4 connections to a shape.
2. Make the connections use orthogonal routing.
3. Drag the shape around.

Expected: The connection visuals and the shape visual follow the mouse when dragging.
Actual: The visuals lag behind.

Attached are a comparison between release 4403 and release 4321 displaying the differences.
Comment 1 Victor Johnsson CLA 2017-07-05 04:53:37 EDT 
Created attachment 269205 [details]
Slower visual updates in 4403
Comment 2 Victor Johnsson CLA 2018-07-02 04:57:59 EDT 
My guess is that the problem lies with org.eclipse.gef.common.collections.ListListenerHelperEx, similar to #518221. However, when I profile what is shown in the gifs above in 4900, there are a few other methods that more time is spent in. See the attached java mission control report for details.
Comment 3 Victor Johnsson CLA 2018-07-02 04:58:54 EDT 
Created attachment 274737 [details]
Java Mission Control report of dragging connections as shown in the gif