Bug 518996 - Commit is not possible should use verbs instead of OK
Summary: Commit is not possible should use verbs instead of OK
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, usability
Depends on:
Blocks:
 
Reported: 2017-06-29 17:53 EDT by Lars Vogel CLA
Modified: 2017-10-15 16:11 EDT (History)
5 users (show)

See Also:

Attachments
Screenshot (10.84 KB, image/png)
2017-06-29 17:53 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2017-06-29 17:53:57 EDT 
Created attachment 269136 [details]
Screenshot

I suggest "Close" instead of "OK".
Comment 1 Lars Vogel CLA 2017-06-29 17:55:51 EDT 
David, maybe something you could coach on our next Eclipse Hackathon?
Comment 2 Thomas Wolf CLA 2017-06-30 17:08:30 EDT 
The real problem here is that this dialog exists at all. The commit commands and buttons in the staging view should simply not be enabled when there are no staged changes. The user should not have the option to perform the action at all when it cannot be performed.

Also, this is a simple statement "Committing is not possible; there are no staged changes."

To which "OK" is a perfectly fine answer and a perfectly fine button label. (It's also the only button in that dialog.)

I'm all for changing button labels to verbs where there might be confusion otherwise, but here I see no need to do anything.

Except enabling/disabling the commit action and buttons properly.
Comment 3 Andrey Loskutov CLA 2017-06-30 17:10:56 EDT 
Please don't forget the "amend" commit use case, where just changing the commit message schould be possible (no other changes). I use this a lot.
Comment 4 Lars Vogel CLA 2017-07-17 07:27:39 EDT 
(In reply to Thomas Wolf from comment #2)
> The real problem here is that this dialog exists at all. 

I agree, but I suggest to handle this by another bug. Improving the label, is already an improvement (see below) and easy to archive.

> To which "OK" is a perfectly fine answer and a perfectly fine button label.
> (It's also the only button in that dialog.)

We discussed this here in the current Hamburg Eclipse Hackathon and we think "Close" is a better description compared to "Ok".
Comment 5 Eclipse Genie CLA 2017-08-07 07:39:32 EDT 
Gerrit change https://git.eclipse.org/r/101335 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=6e2aa3ac99281cee6afe13ff821370b2daef691c
Comment 6 Thomas Wolf CLA 2017-08-07 07:41:54 EDT 
Dialog label changed; button enablement unchanged.