Bug 518702 - Enhancement of the display of unsynchronized status on diagrams
Summary: Enhancement of the display of unsynchronized status on diagrams
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 5.1.0   Edit
Assignee: Laurent Redor CLA
QA Contact: Jessy Mallet CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 526487
  Show dependency tree
 
Reported: 2017-06-23 08:44 EDT by Laurent Fasani CLA
Modified: 2017-11-08 03:37 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Fasani CLA 2017-06-23 08:44:32 EDT 
The enhancement has two parts:
* add the status "Synchronized"/"Unsynchronized" in the status bar
* add an icon in the bottom right corner of the diagram that illustrate this status. This second part is optional under system property
Comment 1 Eclipse Genie CLA 2017-07-03 12:10:11 EDT 
New Gerrit change created: https://git.eclipse.org/r/100563
Comment 2 Laurent Fasani CLA 2017-07-04 10:29:39 EDT 
homologation scenarios:
SCENARIO 1: the status "Synchronized"/"Unsynchronized" in the status bar
1- open any synchronize diagram => check that the Status bar message is coherent with the diagram synchronize status "Synchronized diagram"
2- with contextual menu on diagram, change the Synchronize status to "Unsynchronized" => check that the Status bar message is updated with "Unsynchronized diagram"

SCENARIO 2: diag synchronize status as decorator
1- open any synchronized diagram => check that an icon is displayed in the bottom right corner of the diagram editor
2- Resize editor, moving sides or showing/hiding the palette => check that the icon is still displayed in the bottom right corner of the diagram editor
3- Move some diagram elements so that a scroll bar is displayed. Move the scroll bar => check that the icon is still displayed in the bottom right corner of the diagram editor
4- with contextual menu on diagram, change the Synchronize status to "Unsynchronized" => check that the icon have now a red cross
Comment 3 Laurent Fasani CLA 2017-07-12 11:30:39 EDT 
added https://git.eclipse.org/r/#/c/96002/6
Comment 4 Laurent Fasani CLA 2017-07-12 11:32:15 EDT 
scenario update
for scenario2, set activateDiagramSyncStatusDecorator property system to true
Comment 7 Laurent Fasani CLA 2017-07-31 09:53:06 EDT 
The status decorator in the diagram is an experimental functionality. That's why there is nothing about it in the release notes

It can be activated using the system property activateDiagramSyncStatusDecorator=true
Comment 8 Eclipse Genie CLA 2017-08-28 09:21:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/103766
Comment 10 Eclipse Genie CLA 2017-09-14 03:59:01 EDT 
New Gerrit change created: https://git.eclipse.org/r/105121
Comment 11 Laurent Redor CLA 2017-09-14 07:46:20 EDT 
Finally, the icon that was initially a POC must be really usable:
* A preference must be added to enable it or not
* It must be documented
* It must be tested.
Comment 12 Eclipse Genie CLA 2017-09-14 08:36:40 EDT 
New Gerrit change created: https://git.eclipse.org/r/105141
Comment 13 Eclipse Genie CLA 2017-09-14 08:36:42 EDT 
New Gerrit change created: https://git.eclipse.org/r/105140
Comment 14 Eclipse Genie CLA 2017-09-14 08:36:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/105142
Comment 15 Eclipse Genie CLA 2017-09-15 05:24:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/105188
Comment 21 Florian Barbin CLA 2017-09-20 05:20:45 EDT 
Scenario 1 Validated
Comment 22 Eclipse Genie CLA 2017-09-20 12:25:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/105515
Comment 23 Eclipse Genie CLA 2017-09-20 12:25:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/105514
Comment 24 Laurent Redor CLA 2017-09-21 04:27:57 EDT 
There are 2 problems concerning the icon in the bottom right corner:
* One with zoom that is not correctly managed
* Another with a blink effect when we scroll a big diagram

Steps to validate for SCENARIO 2: diag synchronize status as decorator (replace steps to validate of comment 2): 
1- open any synchronized diagram => check that there is no icon in the bottom right corner, close the diagram
2- Enable preference "Sirius/Sirius Diagram/Show synchronize status decorator on diagram"
3- Open the diagram => Check that an icon is displayed in the bottom right corner of the diagram editor
4- Change the status with constextual menu "Unsynchronized" on the diagram => Check that the icon is changed
5- Resize editor, moving sides or showing/hiding the palette => check that the icon is still displayed in the bottom right corner of the diagram editor
6- Zoom the editor => Check that an icon is displayed in the bottom right corner of the diagram editor
7- Move some diagram elements so that a scroll bar is displayed. Move the scroll bar => Check that the icon is still displayed in the bottom right corner of the diagram editor without blink effect (the icon only disappears during the move)
Comment 25 Laurent Redor CLA 2017-09-21 05:19:21 EDT 
Even with 2 above gerrits, there are bugs when the editor is inderictly reduced (showing palette, from max size to "restore" size, ...). In these cases, the decorator is not visibile. It is not relocated so scroll bar appears.
Comment 26 Eclipse Genie CLA 2017-09-21 06:36:36 EDT 
New Gerrit change created: https://git.eclipse.org/r/105552
Comment 30 Florian Barbin CLA 2017-09-22 03:48:04 EDT 
There is still an issue when performing an arrange all or a reset to origin: the decorator is still at the original lower right corner with scroll bars even if the diagram can be displayed without scroll bar.
Comment 31 Florian Barbin CLA 2017-09-22 04:06:34 EDT 
The behavior is similar with the lock decorator on which this enhancement is technically based. 
Will be fixed in an other bugzilla.
Comment 32 Jessy Mallet CLA 2017-09-25 09:08:35 EDT 
Validated on Sirius Stable 5.1.0.201709221508
Comment 33 Laurent Redor CLA 2017-10-10 09:02:59 EDT 
It remains a problem with the bottom right decorator when doing zoom with mouse wheel.

Steps to reproduce:
* Display the decorator (preference "Sirius/Sirius Diagram/Show synchronize status decorator on diagram")
* Zoom in with the mouse wheel 4 times
* Then zoom out with the mouse wheel until 50%, the decorator is no longer in the bottom right corner but in the middle of the screen.
Comment 34 Eclipse Genie CLA 2017-10-10 09:09:28 EDT 
New Gerrit change created: https://git.eclipse.org/r/106505
Comment 36 Pierre-Charles David CLA 2017-11-08 03:37:46 EST 
Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.